Skip to content

fix(loading): keep a restarted router’s cached component - #110

Merged
vincentkoc merged 1 commit into
mainfrom
fix/component-cache-owner
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/component-cache-owner

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

An old component import that rejected after stop() could evict the component loaded by the restarted router. Preloading a new match for the same route then imported it again.

User Impact

A late failure from a previous session leaves the current session’s component available for reuse.

Why This Change Was Made

An import can remove its cache entry on rejection only while it still owns that entry. Current failures remain retryable.

Evidence

A public-API reproduction started one preload, stopped the router, loaded a replacement, then rejected the old import. A third match caused three component calls before the fix and two after it. Added a regression test and verified the reproduction on Node 24.22.1.

@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 12:19
@vincentkoc
vincentkoc requested a review from a team as a code owner November 20, 2026 12:19
@vincentkoc
vincentkoc merged commit a876b9f into main Nov 20, 2026
12 checks passed
@vincentkoc
vincentkoc deleted the fix/component-cache-owner branch November 20, 2026 12:21
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…-transitions

* origin/main:
  fix(loading): allow preloading after a cancelled revalidation (#108)
  refactor(router): infer private loading and route catalog types (#111)
  fix(loading): keep a restarted router’s cached component (#110)

# Conflicts:
#	CHANGELOG.md
#	src/router.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant