Repository navigation
Conversation
A second navigate of the same match updates history and the match location. A loader failure then published the first location on the router. Publish the joined location on that path, matching success. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesPublish the latest joined navigation location when its component becomes available or its shared load fails. Example: Start loading /page?first=1, navigate to /page?second=1 with the same match identity, then reject the loader.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR fixes a current-main location mismatch with a focused change, useful regression coverage, and built-package proof; no actionable defects were found. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe framework-independent router accepts route definitions, locations, and history adapters, then publishes loading results and observable navigation state. flowchart LR
A[Navigation calls] --> B[Match identity]
B --> C[Shared navigation run]
C --> D[Component and data loading]
D --> E[Match store]
C --> E
A --> F[History adapter]
E --> G[Application subscribers]
Technical reviewBest possible solution: Use the existing navigation run's latest location consistently at component, success, and failure publication. Do we have a high-confidence way to reproduce the issue? The current-main join branch updates ongoing.location while the failure branch publishes its captured first location; the contributor's before trace shows that exact mismatch, though this review ran no target code. Is this the best way to solve the issue? This is the smallest complete fix for the reported mismatch: reuse the location already owned by NavigationRun and preserve match identity, loading, cancellation, and history-adapter contracts. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5acce8720c86. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 20, 2026, 8:12 AM ET / 13:12 UTC. |
What Problem This Solves
Fixes: a failed shared navigation leaves the address bar on the latest location while router state shows the first one.
User Impact
User impact: when two navigations to the same route share one load, a loader failure keeps router location, resolved location, the match, and history on the latest location.
Why This Change Was Made
The in-flight run already stores the joined location, and the success path publishes that value. The failure path and the component publish still closed over the first call. Both now publish the joined location.
This failure path has used the first location since the router match loading refactor on 2026-06-20 (
f047b64, 153 days). That commit has no linked pull request.Evidence
Terminal output from
nodeagainst the built package. The same public calls ran before the patch and after it.Before, history and the match were
?second=1while router location and resolved location stayed?first=1:After, all four agree on
?second=1and status stayserror:Real behavior proof
/page?first=1with a loader that stays pending. Navigate again to/page?second=1with history push. Reject the loader. Read history, router location, resolved location, match location, and status from the public router API.The same command on the previous package printed state and resolved as
?first=1.?second=1. Status is error.