Repository navigation
fix(loading): accept redirect records without a route location as data - #116
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 20, 2026 15:55
vincentkoc
added a commit
that referenced
this pull request
Nov 20, 2026
…replay * origin/main: fix(history): replace the URL on an unmatched redirect (#115) refactor(tests): consolidate pending invalidation scenarios (#118) fix(loading): accept redirect records without a route location as data (#116) fix(loading): ignore a component import from before stop (#113) # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A loader returning an ordinary record with type equal to redirect could put the route in its error state, even when the record contained no redirect location.
User Impact
Consumers can return redirect records such as audit data. Throwing that same record still rejects navigation, and a valid redirect result still follows its destination.
Why This Change Was Made
Loading and navigation now share the guard for the public redirect shape. The exports and declared types are unchanged.
Evidence
The base rejected a returned redirect record with from and to fields. The focused public API check preserves the identity of returned records with either a missing location or a string location, and propagates the identical values when thrown.