Repository navigation
perf(router): preserve pending locations without reading match snapshots - #117
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 20, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Starting a navigation or joining one already in flight could copy every cached match merely to preserve the previous resolved URL.
User Impact
Navigation can update the requested URL without walking the cache. The previous resolved URL stays visible until the destination is published. State subscribers still receive full snapshots.
Why This Change Was Made
The match store already holds the resolved location. Its private location setter can preserve it directly when the caller only supplies a requested URL. Successful navigation still sets a resolved location explicitly, and an unmatched location still clears it.
Evidence
pnpm run checkpassed all 77 tests, formatting, build, type checking, lint, and packed-package import validation after integrating the pending-test cleanup from main.