Skip to content

refactor(tests): consolidate pending invalidation scenarios - #118

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/pending-invalidation-tests
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
refactor/pending-invalidation-tests

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Three fixtures repeated a pending transition and obscured whether refreshing a route affects its cached data on return.

User Impact

This is a test-only change. It removes 88 net test lines and exercises both refresh methods through public navigation and history.

Why This Change Was Made

Keep the different-route and dependency-only cases. Fold the return visit into the route transition and remove two gates that always opened together.

Evidence

The focused public API check completed both pending transitions. On return, invalidation reloaded the original route and untargeted revalidation reused its fresh data. The separate dependency-only case still asserts the history location and new match identity.

@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 15:56
@vincentkoc
vincentkoc requested a review from a team as a code owner November 20, 2026 15:56
@vincentkoc
vincentkoc merged commit ada6a40 into main Nov 20, 2026
12 checks passed
@vincentkoc
vincentkoc deleted the refactor/pending-invalidation-tests branch November 20, 2026 15:58
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…ion-snapshots

* origin/main:
  refactor(tests): consolidate pending invalidation scenarios (#118)
  fix(loading): accept redirect records without a route location as data (#116)
  fix(loading): ignore a component import from before stop (#113)

# Conflicts:
#	test/router-invalidate-pending.test.ts
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…replay

* origin/main:
  fix(history): replace the URL on an unmatched redirect (#115)
  refactor(tests): consolidate pending invalidation scenarios (#118)
  fix(loading): accept redirect records without a route location as data (#116)
  fix(loading): ignore a component import from before stop (#113)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant