Repository navigation
fix(release): use Node patch that rejects compromised CA keys - #69
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR pins release tooling to Node 24.22.1 and documents its rejection of compromised eMudhra certificate keys. Example: The release job sets up Node before installing dependencies and accessing npm.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 3 items remain Keep this PR open: it makes a focused security improvement that is absent from main, and inspection found no introduced code defect. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub release automation selects Node, installs dependencies, validates the package, and publishes through npm trusted publishing; this change affects that tooling runtime. flowchart TD
A[Release trigger] --> B[Setup Node 24.22.1]
B --> C[Install dependencies]
C --> D[Validate package]
D --> E[npm trusted publishing]
E --> F[GitHub release]
Technical reviewBest possible solution: Keep the existing release workflow owner and exact patched-runtime selection, with inspectable evidence of valid-peer access and compromised-key rejection. Do we have a high-confidence way to reproduce the issue? Main uses the broad Node 24 selector, which can select an older cached patch, and upstream source establishes the missing compromised-key rejection; no supplied runtime trace establishes that release jobs actually selected 24.21.0. Is this the best way to solve the issue? An exact security-patch selection through the existing NODE_VERSION input is a small, appropriate fix that preserves package engines, router behavior, CI majors, and publication permissions. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3db9a80449c1. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: unit tests only. SecurityNeeds attention: The patch adopts upstream TLS key revocation without expanding workflow permissions, but its authority-boundary evidence remains incomplete. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 6:22 PM ET / 22:22 UTC. |
What Problem This Solves
Release jobs select Node24.21.0, which can still accept the compromised eMudhra keys.
User Impact
Release jobs use the fixed Node24.22.1 patch. Hosted CI remains required. Linux arm64 incident qualification does not establish native macOS/Windows runtime coverage. Installed consumer runtimes and provider-owned action/runner runtimes are separate obligations. The intentional Node25 CI compatibility lane remains an upstream-release wait; this PR preserves its major.
Why This Change Was Made
Update the release workflow’s existing NODE_VERSION input to the independently qualified fixed24.22.1 patch. Package runtime compatibility and public APIs are unchanged.
Evidence
pnpm checkpasses, including the release package content check. Workflow YAML and actionlint pass;git diff --checkand independent P2 review pass. The fixed Node binaries independently reject all12 incident chains in8 trust modes.