Skip to content

chore(deps): refresh router development tools - #73

Merged
steipete merged 1 commit into
mainfrom
s21/uirouter-deps
Oct 26, 2026
Merged

steipete merged 1 commit into
mainfrom
s21/uirouter-deps

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Refresh the build, test, and type-aware lint tools now that development qualification no longer includes retired Node 25.

User Impact

The router source, published engine range, and 24 public exports are unchanged. The declaration bodies match the previous builder after normalizing export placement and region comments.

Why This Change Was Made

Update tsdown 0.22.14 to 0.23.2, Vitest 4.1.12 to 5.0.5, and oxlint-tsgolint 7.0.2004 to 7.0.2005. The existing two-day dependency policy accepted the selected releases. Preserve strict engine checks and zero runtime dependencies.

Evidence

The full local quality pipeline passed: formatting, build, typecheck, lint, 58 tests, and actual tarball install/import validation, with two test workers. Dependency audit reports no known vulnerabilities. The old and new builders produce equivalent public declaration contracts. Independent P0–P2 review completed without findings; hosted platform checks remain required before landing. No version bump, tag, release, or deployment is included.

@steipete
steipete requested a review from a team as a code owner October 26, 2026 12:12
@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T12:56:38.543817Z f86bf9e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 26, 2026
@clawsweeper

clawsweeper Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR updates tsdown, Vitest, and oxlint-tsgolint and refreshes their locked dependencies.

Example: A contributor installs the locked development tools on Node 26.12.1.

  • Before: The toolchain selects tsdown 0.22.14, Vitest 4.1.12, and oxlint-tsgolint 7.0.2004.
  • After: The toolchain selects tsdown 0.23.2, Vitest 5.0.5, and oxlint-tsgolint 7.0.2005.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Useful, focused maintenance with no actionable defects and substantial exact-head validation; remaining hosted jobs have not completed.
Proof confidence 🌊 off-meta tidepool Not applicable: The ordinary contributor proof gate does not apply to this maintainer-authored tooling update; the body reports full checks and declaration comparison, with passing Linux/Windows hosted checks supporting those claims.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors remain on older build and test tools after the development-runtime restriction requiring them was retired.
Reason: The maintainer-authored direction refreshes the existing toolchain while preserving the package boundary.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored tooling refresh is absent from main, follows the approved retirement of Node 25 development support, and has no actionable findings; two hosted macOS checks remain queued.

Priority: P3
Reviewed head: f86bf9e07ce3130182e2247b39cfe53f7def3aa9

Before merge

None.

Findings

None.

Agent review details

How this fits together

The development toolchain consumes TypeScript source and behavior tests to produce the ESM package, declarations, and validation results.

flowchart LR
  A[Locked development dependencies] --> B[Build and lint tools]
  C[Router TypeScript source] --> B
  B --> D[ESM and declarations]
  E[Router behavior tests] --> F[Vitest]
  D --> G[Package install and import validation]
Loading

Technical review

Best possible solution:

Land the focused dependency refresh once the existing hosted platform checks pass.

Do we have a high-confidence way to reproduce the issue?

This is a maintenance update rather than a bug report; the base manifest directly establishes the older tool versions.

Is this the best way to solve the issue?

Updating the existing dependency owner is appropriately narrow and follows the recorded Node support decision without adding configuration or changing the router contract.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against b3ce1d7fbbdb.

Provenance checked

  • Build and test tool compatibility holds changes intended behavior with a stated reason (c21eaef: Preserve Node 25 frozen installations by retaining tsdown 0.22 and Vitest 4; the subsequently merged runtime qualification decision explicitly retires that constraint.)
  • Locked tooling dependency graph keeps the original intent (8ddc83a: Refresh development tooling and its transitive graph while retaining package compatibility; this update continues that maintenance pattern.)
  • Node qualification changelog entry keeps the original intent (b3ce1d7: Document retirement of Node 25 development qualification; this PR preserves the entry and adds contributor credit.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit b07c01a adds package.json:53 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: b07c01aa822a; files: package.json)
  • Shakker: Raw commit 409c838 adds package.json:48 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 409c8384fefd; files: package.json)
  • Josh Avant: Raw commit b3ce1d7 adds CONTRIBUTING.md:19 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: b3ce1d7fbbdb; files: CONTRIBUTING.md)

Review metrics

Metric Value Why it matters
Change scope 3 dependency selections; 0 router-source or test changes The larger diff consists of lockfile replacement rather than added production machinery.

Root-cause cluster

Relationship: canonical
Canonical: #73
Summary: The maintainer explicitly selected this combined update over the overlapping dependency proposal.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

  • add P3: Routine development-tool maintenance with no demonstrated broken consumer workflow.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine development-tool maintenance with no demonstrated broken consumer workflow.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 8:25 AM ET / 12:25 UTC.

@steipete
steipete merged commit fb31785 into main Oct 26, 2026
15 checks passed
@steipete
steipete deleted the s21/uirouter-deps branch October 26, 2026 12:37
@steipete

Copy link
Copy Markdown
Contributor Author

Merged as fb31785 after all 12 exact-head checks passed. The full local quality pipeline passed: formatting, build, typecheck, lint, 58 tests and actual tarball install/import. Old/new declaration bodies and all 24 public exports match after normalizing export placement and region comments. Audit and independent P0–P2 review are clean.

Post-merge main CI passed: https://github.com/openclaw/uirouter/actions/runs/40323950565. Existing-version release validation also passed: https://github.com/openclaw/uirouter/actions/runs/40323965204 (version=0.1.2, dry_run=true). No version bump, tag or publication was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant