Repository navigation
chore(deps): refresh router development tools - #73
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates tsdown, Vitest, and oxlint-tsgolint and refreshes their locked dependencies. Example: A contributor installs the locked development tools on Node 26.12.1.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored tooling refresh is absent from main, follows the approved retirement of Node 25 development support, and has no actionable findings; two hosted macOS checks remain queued. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe development toolchain consumes TypeScript source and behavior tests to produce the ESM package, declarations, and validation results. flowchart LR
A[Locked development dependencies] --> B[Build and lint tools]
C[Router TypeScript source] --> B
B --> D[ESM and declarations]
E[Router behavior tests] --> F[Vitest]
D --> G[Package install and import validation]
Technical reviewBest possible solution: Land the focused dependency refresh once the existing hosted platform checks pass. Do we have a high-confidence way to reproduce the issue? This is a maintenance update rather than a bug report; the base manifest directly establishes the older tool versions. Is this the best way to solve the issue? Updating the existing dependency owner is appropriately narrow and follows the recorded Node support decision without adding configuration or changing the router contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b3ce1d7fbbdb. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 8:25 AM ET / 12:25 UTC. |
|
Merged as fb31785 after all 12 exact-head checks passed. The full local quality pipeline passed: formatting, build, typecheck, lint, 58 tests and actual tarball install/import. Old/new declaration bodies and all 24 public exports match after normalizing export placement and region comments. Audit and independent P0–P2 review are clean. Post-merge main CI passed: https://github.com/openclaw/uirouter/actions/runs/40323950565. Existing-version release validation also passed: https://github.com/openclaw/uirouter/actions/runs/40323965204 ( |
What Problem This Solves
Refresh the build, test, and type-aware lint tools now that development qualification no longer includes retired Node 25.
User Impact
The router source, published engine range, and 24 public exports are unchanged. The declaration bodies match the previous builder after normalizing export placement and region comments.
Why This Change Was Made
Update tsdown 0.22.14 to 0.23.2, Vitest 4.1.12 to 5.0.5, and oxlint-tsgolint 7.0.2004 to 7.0.2005. The existing two-day dependency policy accepted the selected releases. Preserve strict engine checks and zero runtime dependencies.
Evidence
The full local quality pipeline passed: formatting, build, typecheck, lint, 58 tests, and actual tarball install/import validation, with two test workers. Dependency audit reports no known vulnerabilities. The old and new builders produce equivalent public declaration contracts. Independent P0–P2 review completed without findings; hosted platform checks remain required before landing. No version bump, tag, release, or deployment is included.