Skip to content

improve(ci): split native platform checks across PRs and main - #89

Merged
vincentkoc merged 1 commit into
mainfrom
perf/ci-platform-matrix
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
perf/ci-platform-matrix

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

A PR and its merge each scheduled both Node 22 and Node 24 on Windows and macOS. In the preceding 25 CI runs all seven package checks passed on the first attempt.

User Impact

PRs exercise both native platforms on Node 24. Main exercises both on Node 22. Ubuntu runs the full check on all three Node versions on both events. A manual run still tests all seven pairs together. A Node 22 issue specific to macOS or Windows can now first surface after merge.

Why This Change Was Made

Five package jobs per automatic run cover every OS and Node major. Keeping every OS on main also seeds default-branch pnpm caches for PRs. On the baseline main run, the two Node 24 native jobs used 119 runner-seconds together.

Evidence

Local matrix expansion produced five distinct jobs on PRs, five on pushes, and seven on manual dispatch. Actionlint, YAML parsing, and git diff --check passed. Every selected platform runs the full pnpm run check. Baseline CI

@clawsweeper

clawsweeper Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:feature Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:feature Preliminary submission classification; full source review pending. labels Nov 20, 2026
@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR runs native macOS and Windows checks on Node 24 for PRs and Node 22 for main, retaining all Ubuntu checks and full manual coverage.

Example: A pull request targeting main triggers CI.

  • Before: Seven package jobs run, including Node 22.23.4 and 24.22.1 on both macOS and Windows.
  • After: Five package jobs run: both native platforms use Node 24.22.1, and Ubuntu checks all three Node versions.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Focused, correct automation change with successful hosted PR execution and an explicit owner-approved coverage tradeoff.
Proof confidence 🐚 platinum hermit (4/6) This automation-only change needs no application behavior proof; hosted GitHub Actions executed the new PR matrix successfully, while push and manual selections are supported by source inspection.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors repeatedly spend native runner capacity checking the same OS/Node pairs on a PR and its merge.
Reason: The maintainer-authored direction explicitly accepts later detection of native Node 22 problems in exchange for fewer automatic jobs.

Merge readiness

✅ Ready for maintainer review

Keep this maintainer-authored draft open; the matrix implements the stated coverage tradeoff correctly, hosted PR checks pass, and no actionable defect was found.

Priority: P3
Reviewed head: e512a207efc4274a862888c6e213badf203c3874

Before merge

None.

Findings

None.

Agent review details

How this fits together

GitHub Actions turns PR, main-push, and manual events into OS/Node jobs that install frozen dependencies and run the package quality gate.

flowchart TD
  A[GitHub event] --> B[Event-aware matrix]
  B --> C[Ubuntu on three Node versions]
  B --> D[Native platforms on selected Node versions]
  C --> E[Frozen dependency installation]
  D --> E
  E --> F[Full package quality gate]
Loading

Technical review

Best possible solution:

Retain the compact event-aware matrix and matching documentation with the explicitly accepted post-merge Node 22 coverage tradeoff.

Do we have a high-confidence way to reproduce the issue?

No runtime bug is claimed; baseline CI confirms the former seven-job matrix, and hosted PR execution confirms the new five-job selection.

Is this the best way to solve the issue?

The existing matrix owner handles the split directly, retains full checks for every selected pair, and preserves all seven combinations for manual dispatch.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 6fefc0bb9054.

Provenance checked

  • Native platform qualification frequency changes intended behavior with a stated reason (311db25: The original workflow established cross-platform package checks; later qualification changes retained Node 22/24 across platforms.)
  • Documented development qualification keeps the original intent (b3ce1d7: Retire unpatched Node 25 development qualification while retaining patched Node 22/24 and adding Node 26.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 3b2fb01 adds .github/workflows/ci.yml:43 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 3b2fb01297a5; files: .github/workflows/ci.yml)
  • Josh Avant: Raw commit b3ce1d7 adds .github/workflows/ci.yml:46 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: b3ce1d7fbbdb; files: .github/workflows/ci.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric Value Why it matters
Automatic package jobs 7 → 5 per event Two fewer package jobs per automatic run, while preserving seven combinations on manual dispatch.

Labels

Label changes:

  • add P3: This is a scoped CI efficiency improvement with no router runtime or public API change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a scoped CI efficiency improvement with no router runtime or public API change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 4:10 AM ET / 09:10 UTC.

@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 09:21
@vincentkoc
vincentkoc requested a review from a team as a code owner November 20, 2026 09:21
@vincentkoc
vincentkoc merged commit be17094 into main Nov 20, 2026
16 checks passed
@vincentkoc
vincentkoc deleted the perf/ci-platform-matrix branch November 20, 2026 09:26
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…/test-fixtures

* commit 'be1709487ea73b28c2ff08b1e96403d93de8af65':
  improve(ci): split native platform checks across PRs and main (#89)
  improve(ci): use the prebuilt actionlint image (#88)
  refactor(ci): skip ineligible dispatch events before runner allocation (#94)
  improve(ci): right-size runners for GitHub metadata jobs (#92)
  improve(ci): reuse pnpm packages across lockfile updates (#91)
  refactor(router): consolidate match reuse and path normalization (#90)

# Conflicts:
#	test/router-navigation.test.ts
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…e-mappings

* commit 'be1709487ea73b28c2ff08b1e96403d93de8af65':
  improve(ci): split native platform checks across PRs and main (#89)
  improve(ci): use the prebuilt actionlint image (#88)
  refactor(ci): skip ineligible dispatch events before runner allocation (#94)
  improve(ci): right-size runners for GitHub metadata jobs (#92)
  improve(ci): reuse pnpm packages across lockfile updates (#91)
  refactor(router): consolidate match reuse and path normalization (#90)

# Conflicts:
#	src/matches.ts
#	src/router.ts
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…cription-disposal

* commit 'be1709487ea73b28c2ff08b1e96403d93de8af65':
  improve(ci): split native platform checks across PRs and main (#89)
  improve(ci): use the prebuilt actionlint image (#88)
  refactor(ci): skip ineligible dispatch events before runner allocation (#94)
  improve(ci): right-size runners for GitHub metadata jobs (#92)
  improve(ci): reuse pnpm packages across lockfile updates (#91)
  refactor(router): consolidate match reuse and path normalization (#90)

# Conflicts:
#	src/matches.ts
vincentkoc added a commit that referenced this pull request Nov 20, 2026
…d-revalidation

* commit 'be1709487ea73b28c2ff08b1e96403d93de8af65':
  improve(ci): split native platform checks across PRs and main (#89)
  improve(ci): use the prebuilt actionlint image (#88)
  refactor(ci): skip ineligible dispatch events before runner allocation (#94)
  improve(ci): right-size runners for GitHub metadata jobs (#92)
  improve(ci): reuse pnpm packages across lockfile updates (#91)
  refactor(router): consolidate match reuse and path normalization (#90)

# Conflicts:
#	src/router.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant