only print pair datatype def if emitted smt-lib code will use it - #96
Open
dominicmkennedy wants to merge 1 commit into
Open
only print pair datatype def if emitted smt-lib code will use it#96dominicmkennedy wants to merge 1 commit into
dominicmkennedy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was this todo in smt-printer the code for a while:
# TODO: check for usage of pairs in the program to not always print thiswhere smt-printer would always put this datatype decl in emitted smt-lib code:
(declare-datatypes ((Pair 2)) ((par (X Y) ((pair (first X) (second Y))))))I wanted to use some other solvers including bitwuzla, which doesn't support
declare-datatypes, so this line prevents any of those solvers from running even if the resulting code doesn't include any pairs. so by adding a small check to see if the mlir even has asmt.utils.pairin it, we can conditionally emit the datatype decl, without breaking any functionality, while allowing more compatibility with solvers other than z3