Skip to content

Add set_mtu to packet_link_qualification #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dplore wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add set_mtu to packet_link_qualification #297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a5d42
Add set_mtu to packet_link_qualification
dplore Aug 11, 2025
838301d
revise mtu requirement
dplore Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packet_link_qualification/packet_link_qualification.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import "google/rpc/status.proto";
option go_package =
"github.com/openconfig/gnoi/packet_link_qualification;linkqual";

option (types.gnoi_version) = "1.1.0";
option (types.gnoi_version) = "1.2.0";

service LinkQualification {
// Create will dispatch a create operation for each interface and return.
Expand Down Expand Up @@ -150,6 +150,10 @@ message PacketGeneratorConfiguration {
// Size of packets to inject.
// if unspecified, the default value is 1500 bytes.
uint32 packet_size = 2;

// If true, the Layer 2 MTU of the underlying interface should be set to the
// packet size for the duration of the test.
bool set_mtu = 3;
}

// A packet injector implementation defines that the generator side of the link
Expand All @@ -166,6 +170,10 @@ message PacketInjectorConfiguration {
// if unspecified, the default value is 1500 bytes.
uint32 packet_size = 2;

// If true, the Layer 2 MTU of the underlying interface should be set to the
// packet size for the duration of the test.
bool set_mtu = 3;

// Loopback mode for this qualification.
oneof loopback_mode {
// PMD based loopback encompasses either PHY based port
Expand All @@ -186,7 +194,9 @@ message PmdLoopbackConfiguration {
}

message AsicLoopbackConfiguration {
// This is where any l2/l3/l4 match criteria would be described.
// The L2 MTU of the interface must be set to the packet_size for the
// duration of the test.
uint32 packet_size = 2;

@rszarecki rszarecki Aug 12, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can we also have 'set-MTU' Boolean?

It will be bit redundant but IMHO more intuitive.

Also it is optional file,right? Can we declare default 1500B?

Comment thread
dplore marked this conversation as resolved.
Outdated
}
// GetRequest returns the status for the provided ids.
message GetRequest {
Expand Down
Loading