fix(kueue): harden upgrade tests — drop version-specific labels and assert Workload cleanup - #2269
Merged
Merged
Conversation
jstourac
requested review from
a team,
andyatmiami,
harshad16 and
jiridanek
as code owners
August 25, 2026 13:44
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/lgtm', '/wip', '/build-push-pr-image', '/cherry-pick', '/hold', '/verified'} |
harshad16
approved these changes
Aug 25, 2026
The labels kueue.x-k8s.io/cluster-queue-name and kueue.x-k8s.io/local-queue-name are observability aids introduced in upstream Kueue v0.17.0 (RH Kueue Operator >= 1.4). They do not affect workload admission, pod scheduling, or any functional behavior. Asserting their presence caused the entire kueue upgrade test suite to fail on environments running RH Kueue Operator v1.3.x (upstream v0.16.5), cascading into 9+ test errors/failures despite Kueue functioning correctly. The remaining assertions (kueue.x-k8s.io/managed, queue-name) along with workload admission checks are sufficient to validate Kueue integration across all supported operator versions. Signed-off-by: Jan Stourac <jstourac@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
After deleting a notebook, wait for Kueue to garbage-collect the associated Workload objects. Fail with a clear message if Kueue doesn't clean them up within 60 seconds — this indicates a potential issue with Kueue's reconciliation of StatefulSet-backed workloads. Without this, orphaned Workloads hold kueue.x-k8s.io/resource-in-use finalizers on the ClusterQueue and ResourceFlavor, blocking their deletion and causing teardown timeouts. Signed-off-by: Jan Stourac <jstourac@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
jiridanek
approved these changes
Aug 26, 2026
|
Status of building tag latest: success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kueue.x-k8s.io/cluster-queue-nameandkueue.x-k8s.io/local-queue-namepod labels. These are observability aids introduced in upstream Kueue v0.17.0 (RH Kueue Operator >= 1.4) and are not present on v1.3.x environments. The functional assertions (kueue.x-k8s.io/managed,queue-name, Workload admission) remain.resource-in-usefinalizers on ClusterQueue/ResourceFlavor, blocking teardown.This was split out from #2243 and as such is a partial forward of the #2142.
Related Issues
Please review and indicate how it has been tested
Additional Requirements