E0d/fix actionrow a11y#4270
Open
e0d wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for paragon-openedx-v23 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e0d
force-pushed
the
e0d/fix-actionrow-a11y
branch
from
8e8f365 to
e108851
Compare
The spacer is a purely decorative flex-grow element with no semantic meaning; hiding it from the accessibility tree is more precise than relying on AT heuristics for empty spans. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e0d
force-pushed
the
e0d/fix-actionrow-a11y
branch
from
e108851 to
a49114b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4270 +/- ##
=============================================
Coverage 94.40% 94.40%
=============================================
Files 242 242
Lines 4309 4309
Branches 1020 1021 +1
=============================================
Hits 4068 4068
+ Misses 237 233 -4
- Partials 4 8 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e0d
force-pushed
the
e0d/fix-actionrow-a11y
branch
from
a49114b to
a5f1ac2
Compare
…usage Without guidance, consumers using ActionRow to group interactive controls have no nudge to add ARIA grouping semantics. Adds a README Accessibility section with the recommended pattern (role="group" + aria-label) and a live code example. Also adds interface-level JSDoc in index.tsx pointing TypeScript consumers to the same pattern. Addresses WCAG 4.1.2 Name, Role, Value and 1.3.1 Info and Relationships. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e0d
force-pushed
the
e0d/fix-actionrow-a11y
branch
from
a5f1ac2 to
c15a33d
Compare
| * distinguish multiple ActionRows on the same page: | ||
| * | ||
| * ```jsx | ||
| * <ActionRow role="toolbar" aria-label="Form actions"> |
Contributor
There was a problem hiding this comment.
This is using role="toolbar" but the README example has role="group"
@kblemel any thoughts on which we should be recommending (or the cases in which we should recommend one vs the other)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?Post-merge Checklist