8347740: java/io/File/createTempFile/SpecialTempFile.java failing

[sophia-guo]

I would like to backport 8347740 to jdk8u, which has been backported to jdk21 and jdk17. We see it in our CI. It's a test fix, no risk.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347740 needs maintainer approval
• JDK-8353714 needs maintainer approval
• JDK-8183344 needs maintainer approval

Issues

• JDK-8347740: java/io/File/createTempFile/SpecialTempFile.java failing (Bug - P3)
• JDK-8183344: Better cleanup for jdk/test/java/io/File/createTempFile/SpecialTempFile.java (Bug - P4)
• JDK-8353714: [17u] Backport of 8347740 incomplete (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/794/head:pull/794
$ git checkout pull/794

Update a local copy of the PR:
$ git checkout pull/794
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 794

View PR using the GUI difftool:
$ git pr show -t 794

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/794.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sophia-guo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (5857f187)
• 01: Full - Incremental (26baa48e)
• 00: Full (df53e4ab)

[jerboaa]

I think we should wait until the review for openjdk/jdk11u-dev#3193 concludes before moving on to JDK 8u.

[sophia-guo]

/issue add JDK-8183344

[openjdk]

@sophia-guo
Adding additional issue to issue list: 8183344: Better cleanup for jdk/test/java/io/File/createTempFile/SpecialTempFile.java.

[sophia-guo]

Before the change
https://ci.adoptium.net/view/Test_grinder/job/Grinder/17309/ -Failed
after the change https://ci.adoptium.net/view/Test_grinder/job/Grinder/17315/- passed

[sophia-guo]

/issue add JDK-8353714

[openjdk]

@sophia-guo
Adding additional issue to issue list: 8353714: [17u] Backport of 8347740 incomplete.

[tstuefe]

I am confused about this.

https://bugs.openjdk.org/browse/JDK-8347740 is already marked as backported to 8u461.

And the bug that is supposedly the cause for this issue (https://bugs.openjdk.org/browse/JDK-8345368) was not backported to public JDK 8 but only to the Oracle-internal version, unless I misunderstand the meaning of "8-pool" ?

[jerboaa]

https://bugs.openjdk.org/browse/JDK-8347740 is already marked as backported to 8u461.

That is a backport to Oracle JDK 8u. OpenJDK backports have a fix version of openjdk8uXXX.

[jerboaa]

And the bug that is supposedly the cause for this issue (https://bugs.openjdk.org/browse/JDK-8345368) was not backported to public JDK 8 but only to the Oracle-internal version, unless I misunderstand the meaning of "8-pool" ?

I think Sophia explained that on the JDK 11u review here:
openjdk/jdk11u-dev#3193 (comment)

[jerboaa]

This seems to include a partial backport of https://bugs.openjdk.org/browse/JDK-8183344 which was done before JDK-8347740 (this bug). Please create a separate backport for the former bug and make this patch dependent on the new one. This seems the cleaner approach to do this.

[bridgekeeper]

@sophia-guo This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@sophia-guo This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[jerboaa]

@sophia-guo Could you please reopen the PR and do the requested changes? Thanks! You can use /open to reopen.

[sophia-guo]

/open

[openjdk]

@sophia-guo This pull request is now open