8250839: Improve test template SSLEngineTemplate with SSLContextTemplate

[jerboaa]

Clean (modulo path changes) test-only backport for bringing in JDK-8284047. In particular, this is preparatory work for JDK-8263188 a dependency for JDK-8284047.

Testing

Passed: javax/net/ssl/templates/SSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketTemplate.java
Test results: passed: 3

Thoughts?

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8250839 needs maintainer approval

Issue

• JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate (Enhancement - P3 - Requested)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/809/head:pull/809
$ git checkout pull/809

Update a local copy of the PR:
$ git checkout pull/809
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 809

View PR using the GUI difftool:
$ git pr show -t 809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/809.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/808 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full - Incremental (892575e2)
• 03: Full (42fe7f95)
• 02: Full (a18ae0ce)
• 01: Full - Incremental (b09f14af)
• 00: Full (b09f14af)

[openjdk]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[bridgekeeper]

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

/touch

[openjdk]

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

/touch

[openjdk]

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.

[tstuefe]

I am taking a look.

[tstuefe]

I am not a security expert, but this looks good to me.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8250839-jdk8u-template-SSLEngineTemplate
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

Merged master as the dependent PR integrated. Tests still pass:

Passed: javax/net/ssl/templates/SSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java
Passed: javax/net/ssl/templates/SSLSocketTemplate.java
Test results: passed: 3

@tstuefe Do you mind to re-review? Thanks!

[tstuefe]

still good

[jerboaa]

/approval request Please allow this test-only change into OpenJDK 8u. It's a required dependency for JDK-8284047 which modifies the JDK test code and allows for better testing of crypto updates which we'd like to bring into OpenJDK 8u. Risk is low, as it's a test change only. Reviewed by Thomas Stüfe. Testing is OK.

[jerboaa]

Thanks for the review, Thomas!

[openjdk]

@jerboaa
8250839: The approval request has been created successfully.