Repository navigation
Restore YourMT3 real-checkpoint inference under Transformers 5 - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YourMT3 cannot transcribe after the default install resolves Transformers 5.13.1: its encoder calls removed
get_head_mask, and its decoder expects legacy per-layer key/value tuples while modern T5 uses Cache objects. This PR translates those APIs on the loaded YourMT3 model instance, leaving process-wide Transformers behavior and frozen vendor sources untouched. Its MIDI output on the real checkpoint matches the pre-fix Transformers 4.43.4 fixture exactly.Stacked on #2, which records the immutable pre-fix MIDI baselines. Merge #2 first, then retarget this PR to master and recheck its exact head.
Validation: full suite 89 passed, 3 skipped; real-checkpoint MIDI golden 3/3 passed under Transformers 5.13.1; YourMT3 golden also passed under isolated Transformers 4.43.4. CPU profile, full MIDI messages, and file hashes are checked by the opt-in golden test.