MNT: refactor tests to use cfradial1_sgp_dtree session fixture#347
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 29 29
Lines 6416 6416
=======================================
Hits 6041 6041
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kmuehlbauer
reviewed
Mar 30, 2026
kmuehlbauer
left a comment
kmuehlbauer
left a comment
Collaborator
There was a problem hiding this comment.
@aladinor Thanks! One suggestion here.
Collaborator
|
@aladinor Looks like this is almost done? Anything further needed here? |
Member
Author
|
Ups. Totally forgot this. Let me address your comment @kmuehlbauer |
aladinor
added a commit
to aladinor/xradar
that referenced
this pull request
May 4, 2026
Address @kmuehlbauer's review on openradar#347. Returning the opened DataTree from a session-scoped fixture forced tests that mutate the tree (test_get_sweep_keys, test_map_over_sweeps_non_sweep_nodes) to call .copy() defensively, and made cross-test mutation a possible source of flakes. Return the filename instead and let each test open its own DataTree.
Member
Author
|
@kmuehlbauer Good call — applied in c8dca43. The fixture now returns the filename and each test opens its own DataTree, dropping the defensive |
kmuehlbauer
approved these changes
May 4, 2026
Closes openradar#346. Add cfradial1_sgp_file session fixture in conftest.py that returns the filename for sample_sgp_data.nc. Refactor 8 tests in test_util.py and test_accessors.py to use the fixture instead of inlining DATASETS.fetch + open_cfradial1_datatree. Per @kmuehlbauer's review: the fixture returns the filename (not the opened DataTree) so each test opens its own tree, avoiding cross-test mutation that previously required defensive .copy() calls. Tests covered: - test_get_sweep_keys - test_apply_to_sweeps - test_apply_to_sweeps_inherit_false - test_apply_to_sweeps_inherit_via_map_over_sweeps - test_apply_to_volume - test_map_over_sweeps_decorator_dummy_function - test_map_over_sweeps_apply_dummy_function - test_map_over_sweeps_non_sweep_nodes 132 tests in test_util.py + test_accessors.py pass; black + ruff clean.
aladinor
force-pushed
the
ref/use-cfradial1-sgp-fixture
branch
from
c8dca43 to
c001657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfradial1_sgp_dtreesession fixture toconftest.pytest_util.py(6) andtest_accessors.py(2) to use the shared fixture instead of inliningDATASETS.fetch("sample_sgp_data.nc")+open_cfradial1_datatree()Closes #346
Test plan
test_util.py+test_accessors.pypass🤖 Generated with Claude Code