FIX : enable the function “to_cfradial2” to choose a default storage engine#378
Conversation
* A test 'tests/io/test_cfradial2.py::test_to_cfradial2_selects_default_engine' was added to cover default engine selection in 'to_cfradial2'.
* Two typos in file ‘xradar/io/export/cfradial2.py’ were corrected in order to enable default engine selection.
|
Thanks @chfer for catching this! |
kmuehlbauer
left a comment
There was a problem hiding this comment.
@chfer Please add an entry to history.md. This is good to go.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 94.15% 94.18% +0.03%
==========================================
Files 29 29
Lines 6416 6416
==========================================
+ Hits 6041 6043 +2
+ Misses 375 373 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@chfer Thanks for fixing it, I might have missed it, my bad! |
|
I thought it was my fault, right there from the beginning. But good it is fixed now. |
|
@kmuehlbauer It was me, Sorry! 😃 |
Thank you. This should be done by now :-) |
|
Thanks @chfer, and welcome to xradar! |
This PR aims to correct two small typo bugs in the function “to_cfradial2” located in the module “xradar/io/export/cfradial2.py” at lines 61 and 63.