Skip to content

FIX : enable the function “to_cfradial2” to choose a default storage engine#378

Merged
kmuehlbauer merged 4 commits into
openradar:mainfrom
chfer:fix/cfradial2-default-engine-test
May 5, 2026
Merged

FIX : enable the function “to_cfradial2” to choose a default storage engine#378
kmuehlbauer merged 4 commits into
openradar:mainfrom
chfer:fix/cfradial2-default-engine-test

Conversation

@chfer

@chfer chfer commented May 4, 2026

Copy link
Copy Markdown
Contributor

This PR aims to correct two small typo bugs in the function “to_cfradial2” located in the module “xradar/io/export/cfradial2.py” at lines 61 and 63.

  • In the first commit of this PR branch (fix/cfradial2-default-engine-test - 8b7efd9) a pytest , “tests/io/test_cfradial2.py::test_to_cfradial2_selects_default_engine”,is added which demonstrates that the typos prevent the “to_cfradial2” function from choosing a default storage engine to write the DataTree through “xarray.DataTree.to_netcdf”. The value of the engine there remains “None”, so the test fails.
  • In the second commit (830f81d) the two typos are corrected and the test succeeds.

Christophe Férauge added 2 commits May 4, 2026 15:59
* A test 'tests/io/test_cfradial2.py::test_to_cfradial2_selects_default_engine' was added to cover default engine selection in 'to_cfradial2'.
* Two typos in file ‘xradar/io/export/cfradial2.py’ were corrected in order to enable default engine selection.
@kmuehlbauer

Copy link
Copy Markdown
Collaborator

Thanks @chfer for catching this!

@kmuehlbauer kmuehlbauer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chfer Please add an entry to history.md. This is good to go.

@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (279d33b) to head (ed20719).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.03%     
==========================================
  Files          29       29              
  Lines        6416     6416              
==========================================
+ Hits         6041     6043       +2     
+ Misses        375      373       -2     
Flag Coverage Δ
notebooktests 0.00% <0.00%> (ø)
unittests 94.18% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@syedhamidali

Copy link
Copy Markdown
Member

@chfer Thanks for fixing it, I might have missed it, my bad!

@kmuehlbauer

Copy link
Copy Markdown
Collaborator

I thought it was my fault, right there from the beginning. But good it is fixed now.

@syedhamidali

Copy link
Copy Markdown
Member

@kmuehlbauer It was me, Sorry! 😃

@chfer

chfer commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@chfer Please add an entry to history.md. This is good to go.

Thank you. This should be done by now :-)

@kmuehlbauer kmuehlbauer enabled auto-merge (squash) May 5, 2026 14:27
@kmuehlbauer kmuehlbauer merged commit d723857 into openradar:main May 5, 2026
11 checks passed
@kmuehlbauer

Copy link
Copy Markdown
Collaborator

Thanks @chfer, and welcome to xradar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants