Towards default nominal angles#386
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 94.20% 94.19% -0.01%
==========================================
Files 29 29
Lines 6417 6461 +44
==========================================
+ Hits 6045 6086 +41
- Misses 372 375 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @kmuehlbauer for handling this issue. This is a more elaborated solution. It remains quite simple. I like it. Is it the plan to tackle each format separately? I think for rainbow the nominal angle is included in the metadata. |
|
@egouden The only thing I'm still not quite sure: If we have a missing and a duplicate ray for some reason, like 0, 0, 1,..., 357, 359, it would create the nominal angles 0, 1, ..., 358, 359. Finally this would return an array which is one off for most of the sweep. I'll ponder about this a bit more, maybe we can get this right, too. About the nominal angles: if formats support that, we should implement it. Otherwise we still could get nominal angles by auto extraction/reindex_dict. Would be nice to have conforming behaviour throughout the readers, though. |
history.md