MNT: Refactor CfRadial1#387
Open
syedhamidali wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 94.20% 94.35% +0.15%
==========================================
Files 29 29
Lines 6417 6398 -19
==========================================
- Hits 6045 6037 -8
+ Misses 372 361 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add tests for the previously-uncovered branches in the CfRadial1 writer so codecov patch coverage passes: - to_cfradial1(filename=None) auto-derives the output name - calculate_sweep_indices warns and skips a sweep group with no elevation - _build_cfradial1_dataset raises ValueError on dtree=None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
history.mdCleans up the CfRadial1 writer ahead of v1.0: descriptive helper names;
_extract_root_dataset_combine_sweeps_map_radar_calibration_collect_sweep_metadataclearer locals/named constants, fixes the calibs bool/variable collision, more robust error handling (history attr, missing elevation, dtree=None), and a shared _build_cfradial1_dataset reused by transform.to_cfradial1 to drop ~40 duplicated lines. No behavior change; all CfRadial1/transform tests pass.