added an epsilon to the inside diameter of the rings to prevent bolts through holes resulting in 'WARNING: CSG normalisation resulted in empty tree'; switched to using cubes for hexagons; added 626 bearing size; #16
Open
McNeight wants to merge 5 commits into
Conversation
… through holes resulting in 'WARNING: CSG normalisation resulted in empty tree'
hyperair
requested changes
Mar 29, 2020
hyperair
left a comment
hyperair
left a comment
There was a problem hiding this comment.
Generally okay except for the comments I left
| module motor(model=Nema23, size=NemaMedium, dualAxis=false, pos=[0,0,0], orientation = [0,0,0]) { | ||
|
|
||
| length = lookup(size, model); | ||
| motorDef = NemaDefinitions[model]; |
There was a problem hiding this comment.
It looks like this changes the format of the model parameter from the motor definition structure to an array index. This isn't acceptable because it'll break many designs floating around the internet that use this module.
|
|
||
| length = lookup(size, model); | ||
| motorDef = NemaDefinitions[model]; | ||
| echo(NemaDefinitions[14]); |
There was a problem hiding this comment.
This echo shouldn't be here, I think.
| //takes a metric screw/nut size and looksup nut dimensions | ||
| radius = METRIC_NUT_AC_WIDTHS[size]/2+tolerance; | ||
| height = METRIC_NUT_THICKNESS[size]+tolerance; | ||
| radius = METRIC_NUT_AC_WIDTHS[size]+2*tolerance; |
There was a problem hiding this comment.
Suggested change
| radius = METRIC_NUT_AC_WIDTHS[size]+2*tolerance; | |
| width = METRIC_NUT_AC_WIDTHS[size]+2*tolerance; |
This isn't really a radius any more.
| if (proj == -1) | ||
| { | ||
| cylinder(r= radius, h=height, $fn = 6, center=[0,0]); | ||
| translate([0,0,(height/2)-tolerance]) hexagon(height=radius, depth=height); |
There was a problem hiding this comment.
Suggested change
| translate([0,0,(height/2)-tolerance]) hexagon(height=radius, depth=height); | |
| translate([0,0,(height/2)-tolerance]) hexagon(height=width, depth=height); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.