Partially toothed gears#24
Open
AlessioGiambrone wants to merge 1 commit into
Open
Conversation
Adding the ability to generate partially toothed gears, using a parameter (real_teeth) for specifying the number of desired teeth. If omitted (default is 0) its value will be replaced by the actual number of teeth.
Irev-Dev
reviewed
Feb 22, 2018
Irev-Dev
left a comment
Irev-Dev
left a comment
There was a problem hiding this comment.
Hi Alessio,
I'm trying to test this code in order to approve it to be merged, and the changes to the bevel_gear module look good however I'm struggling to test the gear_shape as unlike bevel_gear it dose not have default value define in the module and I'm not to savvy on gear design principles so I don't know what are reasonable values (I tried some arbitrary ones and the resulting same was not a gear). I would greatly appreciate it if you could provide some values for the gear_shape module so I can test that real_teeth is working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to generate partially toothed gears, using a parameter (real_teeth) for specifying the number of desired teeth. If omitted (default is 0) its value will be replaced by the actual number of teeth.