[release-4.22] OCPBUGS-113718: Remove CustomNoUpgrade featureSet from disconnected UI by andfasano · Pull Request #3984 · openshift-assisted/assisted-installer-ui

andfasano · 2026-08-25T12:34:16Z

This is a manual cherry-pick of #3954, since the original backport to release-4.22 failed due some conflicts.

This patch is required to properly release the OVE ISO 4.22, otherwise it won't be possible to further upgrade the cluster once installed

…t API, so it no longer needs to be explicitly enabled via a feature gate. This also removes the CustomNoUpgrade featureSet which was only needed to allow setting that custom feature gate. manual cherry-pick from 03cbb90 (AGENT-1570)

openshift-ci-robot · 2026-08-25T12:34:23Z

@andfasano: This pull request references Jira Issue OCPBUGS-113718, which is invalid:

expected the bug to target either version "4.22.0." or "openshift-4.22.0.", but it targets "5.0.0" instead
expected Jira Issue OCPBUGS-113718 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #3954, since the original backport to release-4.22 failed due some conflicts.

This patch is required to properly release the OVE ISO 4.22, otherwise it won't be possible to further upgrade the cluster once installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-25T12:34:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d1ebdb09-091c-46ff-aef4-b5fd80e862cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-25T12:34:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign celdrake for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-08-25T12:34:27Z

Welcome @andfasano! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉

openshift-ci · 2026-08-25T12:34:28Z

Hi @andfasano. Thanks for your PR.

I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

andfasano · 2026-08-25T12:36:21Z

/jira refresh

openshift-ci-robot · 2026-08-25T12:36:25Z

@andfasano: This pull request references Jira Issue OCPBUGS-113718, which is invalid:

expected Jira Issue OCPBUGS-113718 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-08-25T12:37:25Z

/jira refresh

openshift-ci-robot · 2026-08-25T12:37:32Z

@andfasano: This pull request references Jira Issue OCPBUGS-113718, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-113711 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-113711 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-08-25T12:37:52Z

/test ?

openshift-ci · 2026-08-25T12:38:07Z

@andfasano: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

asmasarw · 2026-08-25T12:42:54Z

/retest

asmasarw · 2026-08-25T12:43:49Z

/ok-to-test

andfasano · 2026-08-25T12:48:38Z

/test ?

andfasano · 2026-08-25T12:49:14Z

/test e2e-agent-compact-ipv4-iso-no-registry

bfournie · 2026-08-25T12:56:07Z

/lgtm

openshift-ci · 2026-08-25T12:56:10Z

@bfournie: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jgyselov · 2026-08-26T07:09:32Z

/retest

andfasano · 2026-08-26T14:46:53Z

The current iso-no-registry failure is due the missing dependency bump in openshift/installer and openshift/mco.

Requires openshift/machine-config-operator#6418

andfasano · 2026-08-26T14:47:01Z

/hold

bfournie · 2026-08-27T20:32:05Z

/test e2e-agent-compact-ipv4-iso-no-registry

pawanpinjarkar · 2026-08-27T23:59:32Z

/test e2e-agent-compact-ipv4-iso-no-registry

bfournie · 2026-08-28T17:49:46Z

/test e2e-agent-compact-ipv4-iso-no-registry

openshift-ci Bot requested review from asmasarw and jgyselov August 25, 2026 12:34

openshift-ci Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2026

Uh oh!

Conversation

andfasano commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

coderabbitai Bot commented Aug 25, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

andfasano commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

andfasano commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

andfasano commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

asmasarw commented Aug 25, 2026

Uh oh!

asmasarw commented Aug 25, 2026

Uh oh!

andfasano commented Aug 25, 2026

Uh oh!

andfasano commented Aug 25, 2026

Uh oh!

bfournie commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

jgyselov commented Aug 26, 2026

Uh oh!

andfasano commented Aug 26, 2026

Uh oh!

andfasano commented Aug 26, 2026

Uh oh!

bfournie commented Aug 27, 2026

Uh oh!

pawanpinjarkar commented Aug 27, 2026

Uh oh!

bfournie commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants