CNF-23307: Standardize error wrapping with %w across the codebase

[sebrandon1]

Summary

• Replace %s and %v with %w in all fmt.Errorf calls to enable proper error chain unwrapping via errors.Is() and errors.As()
• 30 lines across 9 files — each change is a single-character format verb substitution with no behavioral changes
• log.Errorf calls (logrus) are left as-is since logrus does not support %w

Files changed

• cmd/generate/generate.go (10)
• pkg/commatrix-creator/commatrix.go (5)
• pkg/utils/utils.go (5)
• pkg/firewall/machineconfig.go (3)
• pkg/endpointslices/endpointslices.go (3)
• pkg/types/types.go (1)
• pkg/matrix-diff/matrix-diff.go (1)
• test/pkg/firewall/firewall.go (1)
• test/pkg/cluster/cluster.go (1)

Related to

• redhat-best-practices-for-k8s/certsuite#3730 — %w error wrapping in certsuite (open)
• openshift/tls-scanner#70 — %w error wrapping in tls-scanner (merged)
• crc-org/crc#5180 — %w error wrapping in crc (merged)
• openshift-kni/lifecycle-agent#6319 — bare error wrapping in lifecycle-agent (open)
• redhat-best-practices-for-k8s/certsuite#3633 — bare error wrapping in certsuite (merged)
• redhat-best-practices-for-k8s/certsuite#3627 — bare error wrapping in certsuite (merged)

Test plan

• make lint passes clean
• make test passes (all unit tests green)
• CI checks pass

Jira: CNF-23307

[aabughosh]

/lgtm

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-23307 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Replace %s and %v with %w in all fmt.Errorf calls to enable proper error chain unwrapping via errors.Is() and errors.As()
• 30 lines across 9 files — each change is a single-character format verb substitution with no behavioral changes
• log.Errorf calls (logrus) are left as-is since logrus does not support %w

Files changed

• cmd/generate/generate.go (10)
• pkg/commatrix-creator/commatrix.go (5)
• pkg/utils/utils.go (5)
• pkg/firewall/machineconfig.go (3)
• pkg/endpointslices/endpointslices.go (3)
• pkg/types/types.go (1)
• pkg/matrix-diff/matrix-diff.go (1)
• test/pkg/firewall/firewall.go (1)
• test/pkg/cluster/cluster.go (1)

Test plan

• make lint passes clean
• make test passes (all unit tests green)
• CI checks pass

Jira: CNF-23307

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oribon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oribon, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [oribon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment