Add cluster unlock functionality to the cluster lock only mechanism - #115
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…thout lockOnly, lockOnly works as before
kpouget
left a comment
kpouget
left a comment
There was a problem hiding this comment.
thanks Avi, looks good overall,
just a minor comment on a log level and we should be good 👍🏻
This code path is unreachable in practice (lockUntil is already validated at creation), and only concerns the fjob creator rather than cluster admins, so warning-level logging was too noisy per review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
|
thanks Avi, great work 🙏🏻 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashtarkb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
This PR allows to unlock the cluster after it was locked continuing the work for lock only operations.
spec.lockOnly - holds cluster-slot quota without running a pipeline. Implies
exclusive: trueand requirescluster. The job staysAdmitteduntil deleted, shut down, or (withlockUntil) until it auto-expires.spec.lockUntil - Only valid with 'lockOnly: true' . ISO 8601 UTC timestamp (e.g., 2026-08-23T22:00:00Z) at which the lock is released automatically. Omit to hold the lock indefinitely.