Skip to content

fournos-ui: add rhaiis submit form, CPT pipelines, and job detail enhancements - #117

Open
Harshith-umesh wants to merge 2 commits into
openshift-psap:mainfrom
Harshith-umesh:fournos-ui-app
Open

fournos-ui: add rhaiis submit form, CPT pipelines, and job detail enhancements#117
Harshith-umesh wants to merge 2 commits into
openshift-psap:mainfrom
Harshith-umesh:fournos-ui-app

Conversation

@Harshith-umesh

Copy link
Copy Markdown
Member

Summary

  • Add dynamic RHAIIS-specific submit form with accelerator/engine/cluster/model/workload selection
  • Add CPT (Continuous Performance Testing) pipeline support with matrix UI for model x workload multi-job submission
  • Support TP size inference from model key suffix and Forge models.yaml for correct GPU count
  • Fix submit form silently failing due to hidden required field validation and duplicate form field names
  • Fix exclusive checkbox always sending false due to hidden input override
  • Switch theme to light, improve layout, add detailed job failure info display

Split from #113 — this PR contains only the UI/application changes.

Test plan

  • Submit a single RHAIIS job — verify form submits correctly
  • Submit a CPT pipeline — verify matrix jobs are created
  • Toggle exclusive checkbox — verify correct value is sent
  • Switch between generic and RHAIIS forms — verify inactive fields are disabled
  • Check job detail page for failed jobs — verify exit codes and logs display

Made with Cursor

…ancements

- Add dynamic rhaiis project form with accelerator/engine/cluster/model/workload
  selection, fetched from Forge's GitHub config
- Add CPT (Continuous Performance Testing) pipeline support with matrix UI for
  model x workload selection and multi-job submission
- Support per-model config overrides and TP size inference from /tpN key suffix
  in CPT definitions for GPU-aware Kueue admission
- Parse tensor-parallel-size from Forge's models.yaml to set correct
  hardware.gpuCount on FournosJobs
- Fix submit form silently failing due to hidden field validation — disable
  inactive sub-form fields so they are excluded from both validation and
  submission when switching between generic, RHAIIS-single, and RHAIIS-CPT modes
- Fix broken exclusive checkbox (hidden input always overrode checkbox value)
- Add engine version auto-population and invalid combo validation
- Switch theme from dark to light, improve layout
- Display detailed job failure info: pod exit codes, termination reasons,
  auto-load logs for failed pods
- Enforce cancel-only for active jobs on history page

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sjmonson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8fe323e5-6b38-4b36-a5bd-da7b35013f92


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Move all RHAIIS-specific backend logic (config fetcher, CPT submit,
job helpers) into app/projects/rhaiis.py and UI (CSS, HTML, JS) into
templates/projects/rhaiis_submit.html. Extract shared GitHub helpers
into app/github.py. The main app now mounts the RHAIIS router and
delegates via build_job_overrides, making the architecture extensible
for future projects.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant