Skip to content

Promote GCD to GA in 4.22 - #3034

Open
patrickdillon wants to merge 1 commit into
openshift:release-4.22from
patrickdillon:ga-gcd-422
Open

patrickdillon wants to merge 1 commit into
openshift:release-4.22from
patrickdillon:ga-gcd-422

Conversation

@patrickdillon

Copy link
Copy Markdown
Contributor

Promotes GCD feature gate to GA in 4.22.

SBAR

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b7e2f8d8-7026-4aed-988c-a301e3f54174

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2026
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed

Copy link
Copy Markdown
Contributor

Will need to sort verify issues before we can continue here

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2026
@patrickdillon

Copy link
Copy Markdown
Contributor Author

/retest-required

Promotes GCD feature gate to GA in 4.22.
@openshift-ci

openshift-ci Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion b02757d link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon

Copy link
Copy Markdown
Contributor Author

After rebasing and regenerating, tests are passing. Ready for a second look, thanks!

@JoelSpeed

Copy link
Copy Markdown
Contributor

@patrickdillon the feature promotion appears to be looking at all GCP tests, do we have specific periodics set up to test this feature?

@patrickdillon

Copy link
Copy Markdown
Contributor Author

@patrickdillon the feature promotion appears to be looking at all GCP tests, do we have specific periodics set up to test this feature?

Ah good point, we currently only have presubmits on 4.22. I've just now opened a pr for the 4.22 periodics: openshift/release#85236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants