[release-4.20] SPLAT-2867: Add vSphere multi vCenter Day 2 by vr4manta · Pull Request #3038 · openshift/api

vr4manta · 2026-09-14T13:49:18Z

SPLAT-2867

Changes

Created new VSphereMultiVCenterDay2 feature gate
Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

(cherry picked from commit 76aebe7)

(cherry picked from commit 727806d)

(cherry picked from commit 43def11)

…e, and other review suggestions. (cherry picked from commit 7b21e9d)

(cherry picked from commit af78729)

(cherry picked from commit 291a26c)

…2 feature gate to TP"" (cherry picked from commit 1bf28d7)

(cherry picked from commit db1ed9c)

(cherry picked from commit 5c06b67)

Cherry-picking PRs openshift#2783, openshift#2784, openshift#2886, openshift#2932 from master required manual conflict resolution in several generated files (features.md, openapi, payload-manifests/featuregates); this regenerates them via `make update` to ensure they match the source of truth.

git's rename-based cherry-pick merge for db1ed9c (PR openshift#2932) matched the wrong source hunk when applying to the CustomNoUpgrade-featureset CRD manifests (a hand-maintained target not regenerated by `make update` on this branch), silently dropping the "all failure domains must have a corresponding vCenter entry" rule instead of adding it. Caught by the config/v1 integration suite. Backfilled the rule to match TechPreviewNoUpgrade (CustomNoUpgrade enables all gates, so content should be a superset) and re-synced the payload-manifests copies.

openshift-ci · 2026-09-14T13:49:21Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-09-14T13:49:21Z

@vr4manta: This pull request references SPLAT-2867 which is a valid jira issue.

Details

In response to this:

SPLAT-2867

Changes

Created new VSphereMultiVCenterDay2 feature gate

Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

SPLAT-2649: Added vSphere Day 2 logic to CRDs #2784

Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay2 feature gate to TP"" #2886

SPLAT-2827: Added vSphere failure domain to vcenter check #2932

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-09-14T13:49:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eed38c94-de2b-4878-bbd7-ba5c84ce4eef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-09-14T13:49:28Z

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

vr4manta · 2026-09-15T17:27:02Z

/pipeline required

openshift-merge-bot · 2026-09-15T17:27:05Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview

vr4manta · 2026-09-15T17:28:20Z

/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview

vr4manta · 2026-09-21T11:17:07Z

/retest

vr4manta · 2026-09-22T11:54:54Z

/pipeline required

openshift-merge-bot · 2026-09-22T11:54:58Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview

everettraven

/approve
/lgtm
/label backport-risk-assessed

openshift-ci · 2026-09-22T13:40:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

redhat-chai-bot · 2026-09-22T16:05:31Z

/override-sticky ci/prow/e2e-azure

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running Azure e2e/integration presubmit (pull-ci-openshift-api-release-4.20-e2e-azure); the job definition uses the openshift-e2e-azure workflow with Azure cluster provisioning, install, and openshift-e2e-test.
Revision check: run 760409d086356df556f9d05806a261ec7de397b6; current PR HEAD 760409d086356df556f9d05806a261ec7de397b6; match.
Execution status: Tests executed after successful cluster provisioning. openshift-tests completed with 1 blocking failure, 0 informing failures, 1803 passed, and 1846 skipped. The failing test was [sig-network] Conntrack proxy implementation should not be vulnerable to the invalid conntrack state bug [Privileged] [Suite:openshift/conformance/parallel] [Suite:k8s].
Completed supporting jobs: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/e2e-upgrade-out-of-change, ci/prow/e2e-vsphere-ovn, and ci/prow/e2e-vsphere-ovn-techpreview passed. tide remained pending and was not used as positive signal.
Fleet-wide failure rate: This exact presubmit job was 50.0% passing in the last 30 days (1/2) and 60.0% in the last 90 days (3/5). For the failing test, OCP 4.20 pass rate was 96.9% (190/196) overall and 89.5% (34/38) on Azure.
Open regressions: No separate 4.20 Component Readiness regression was identified beyond the linked known issue; the test has an explicit Sippy bug_tests association to OCPBUGS-90520.
Linked bugs: OCPBUGS-90520 is ASSIGNED and explicitly linked to the exact failing test through bug_tests; the issue tracks the conntrack invalid-state failure. The older related OCPBUGS-60610 association is Closed.
Overlap assessment: No direct or indirect overlap identified. PR #3038 changes vSphere multi-vCenter Day 2 API types, feature gates, CRD/generated manifests, and API validation tests. It does not modify conntrack, OVN-Kubernetes, networking, kernel behavior, or Azure test infrastructure.
Missing-coverage risk: Low for this specific failure: the Azure e2e suite executed, the failure is isolated to a known fleet-wide networking test, the same PR passed this job on September 15, and the PR's API/feature-gate changes are outside the failing tested surface. Residual Azure e2e coverage remains represented by the other completed e2e jobs; tide was still pending.
Prior bot activity on this SHA: /test e2e-azure was already triggered on 2026-09-22T11:54:58Z; an earlier /retest was posted on 2026-09-21T11:17:07Z. No prior override for this job/SHA was recorded.
Rationale: The failure is the known intermittent conntrack invalid-state failure, with the exact test-to-bug association recorded in Sippy and current Jira status ASSIGNED. The same PR previously passed, and unrelated jobs show the same signature. This meets the executed-test override gates.

If you disagree with this assessment, rerun the current job with /test e2e-azure.

AI-generated. Review for accuracy.

openshift-ci · 2026-09-22T16:10:31Z

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-azure

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/e2e-azure

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running Azure e2e/integration presubmit (pull-ci-openshift-api-release-4.20-e2e-azure); the job definition uses the openshift-e2e-azure workflow with Azure cluster provisioning, install, and openshift-e2e-test.
Revision check: run 760409d086356df556f9d05806a261ec7de397b6; current PR HEAD 760409d086356df556f9d05806a261ec7de397b6; match.
Execution status: Tests executed after successful cluster provisioning. openshift-tests completed with 1 blocking failure, 0 informing failures, 1803 passed, and 1846 skipped. The failing test was [sig-network] Conntrack proxy implementation should not be vulnerable to the invalid conntrack state bug [Privileged] [Suite:openshift/conformance/parallel] [Suite:k8s].
Completed supporting jobs: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/e2e-upgrade-out-of-change, ci/prow/e2e-vsphere-ovn, and ci/prow/e2e-vsphere-ovn-techpreview passed. tide remained pending and was not used as positive signal.
Fleet-wide failure rate: This exact presubmit job was 50.0% passing in the last 30 days (1/2) and 60.0% in the last 90 days (3/5). For the failing test, OCP 4.20 pass rate was 96.9% (190/196) overall and 89.5% (34/38) on Azure.
Open regressions: No separate 4.20 Component Readiness regression was identified beyond the linked known issue; the test has an explicit Sippy bug_tests association to OCPBUGS-90520.
Linked bugs: OCPBUGS-90520 is ASSIGNED and explicitly linked to the exact failing test through bug_tests; the issue tracks the conntrack invalid-state failure. The older related OCPBUGS-60610 association is Closed.
Overlap assessment: No direct or indirect overlap identified. PR #3038 changes vSphere multi-vCenter Day 2 API types, feature gates, CRD/generated manifests, and API validation tests. It does not modify conntrack, OVN-Kubernetes, networking, kernel behavior, or Azure test infrastructure.
Missing-coverage risk: Low for this specific failure: the Azure e2e suite executed, the failure is isolated to a known fleet-wide networking test, the same PR passed this job on September 15, and the PR's API/feature-gate changes are outside the failing tested surface. Residual Azure e2e coverage remains represented by the other completed e2e jobs; tide was still pending.
Prior bot activity on this SHA: /test e2e-azure was already triggered on 2026-09-22T11:54:58Z; an earlier /retest was posted on 2026-09-21T11:17:07Z. No prior override for this job/SHA was recorded.
Rationale: The failure is the known intermittent conntrack invalid-state failure, with the exact test-to-bug association recorded in Sippy and current Jira status ASSIGNED. The same PR previously passed, and unrelated jobs show the same signature. This meets the executed-test override gates.

If you disagree with this assessment, rerun the current job with /test e2e-azure.

AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vr4manta · 2026-09-22T18:43:16Z

/verified by CI

vr4manta · 2026-09-22T18:43:23Z

/retest

openshift-ci-robot · 2026-09-22T18:43:28Z

@vr4manta: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-23T01:00:17Z

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	`760409d`	link	false	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JoelSpeed · 2026-09-23T12:25:48Z

This forms part of an approved feature backport
/label jira/valid-bug

vr4manta and others added 11 commits September 14, 2026 08:36

Added new feature gate VSphereMultiVCenterDay2

424381b

(cherry picked from commit 76aebe7)

Added vSphere Day 2 logic to CRDs

d409749

(cherry picked from commit 727806d)

Added vSphere Day 2 tests

4a0a0f6

(cherry picked from commit 43def11)

Modified parent logic to not check size, but only changes in existenc…

cdcc0d1

…e, and other review suggestions. (cherry picked from commit 7b21e9d)

Added some ratcheting tests to cover change in min size of vCenters

f6577eb

(cherry picked from commit af78729)

Updated vcenter logic to make sure no server switching occurs

43db680

(cherry picked from commit 291a26c)

Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay…

c225300

…2 feature gate to TP"" (cherry picked from commit 1bf28d7)

Added vSphere failure domain to vcenter check

e1bd70c

(cherry picked from commit db1ed9c)

Added vSphere failure domain to vcenter ratcheting tests

0425a9d

(cherry picked from commit 5c06b67)

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2026

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 14, 2026

openshift-ci Bot requested review from everettraven and yuqi-zhang September 14, 2026 13:50

Generated changes for release unique CRDs

760409d

vr4manta force-pushed the SPLAT-2867 branch from 1c56406 to 760409d Compare September 21, 2026 16:58

everettraven approved these changes Sep 22, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 22, 2026

openshift-ci Bot assigned gangwgr Sep 22, 2026

openshift-ci Bot assigned everettraven Sep 22, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 22, 2026

openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 23, 2026

openshift-merge-bot Bot merged commit b32f49f into openshift:release-4.20 Sep 23, 2026
26 checks passed

Conversation

vr4manta commented Sep 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

openshift-ci-robot commented Sep 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

coderabbitai Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 15, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

vr4manta commented Sep 21, 2026

Uh oh!

vr4manta commented Sep 22, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 22, 2026

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 22, 2026

Uh oh!

redhat-chai-bot commented Sep 22, 2026

Uh oh!

openshift-ci Bot commented Sep 22, 2026

Uh oh!

vr4manta commented Sep 22, 2026

Uh oh!

vr4manta commented Sep 22, 2026

Uh oh!

openshift-ci-robot commented Sep 22, 2026

Uh oh!

openshift-ci Bot commented Sep 23, 2026

Uh oh!

JoelSpeed commented Sep 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vr4manta commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Sep 14, 2026 •

edited

Loading