[release-4.17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements

[bpickard22]

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b70c6cad-d74b-4b38-82a3-a846b2ad90a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@bpickard22: This pull request references release-4 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.z" version, but no target version was set.

Details

In response to this:

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bpickard22]

/retest-required

[bpickard22]

/retest-required

[bpickard22]

/retest

[bpickard22]

/retest

[bpickard22]

hypershift conformance lane is permafailing on a provisioning timeout - this is unrelated to the changes in this pr

[bpickard22]

/retest-required

[openshift-ci]

@bpickard22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	92c457e	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[danwinship]

/override ci/prow/e2e-aws-ovn-hypershift-conformance
(no way a whereabouts change would affect a hypershift job)

/label backport-risk-assessed

[openshift-ci]

@danwinship: danwinship unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift-conformance
(no way a whereabouts change would affect a hypershift job)

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knobunc]

/override ci/prow/e2e-aws-ovn-hypershift-conformance

[openshift-ci]

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-ovn-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pperiyasamy]

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

@bpickard22 why isn't this cherry-pick of 4.18 commit a0b2b40 ?

[bpickard22]

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)
(cherry picked from commit 1e4bacb)

@bpickard22 why isn't this cherry-pick of 4.18 commit a0b2b40 ?

good question I dont remember why i didnt use the 4.18 commit, probably should have. the diff is identical so it shouldnt matter @pperiyasamy

[bpickard22]

@pperiyasamy if you want I can update this to pick from 4.18, but its going to have the same conflict and then im going to have to get override from staff eng again because the hypershift job is perma failing

[pperiyasamy]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpickard22, pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pperiyasamy]

/jira refresh

[openshift-ci-robot]

@pperiyasamy: This pull request references release-4 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.z" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bpickard22]

/jira refresh

[openshift-ci-robot]

@bpickard22: This pull request references release-4 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.z" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcaamano]

/retitle [release-4:17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements

[jcaamano]

/retitle [release-4.17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements

[openshift-ci-robot]

@bpickard22: This pull request references Jira Issue OCPBUGS-85244, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-78833 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-78833 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.