HIVE-3205: TLS curves ("group preferences") - #2954
Conversation
The main objective is to pick up openshift/library-go#2414 so we can implement TLS curves in a subsequent commit.
Following on from HIVE-3007 / openshift#2800, subsume the upstream addition to library-go that gleans TLS curves (aka "group preferences") from the APIServer into hiveadmission (the only component that directly does TLS). Assisted-By: cursor/grok
|
@2uasimojo: This pull request references HIVE-3205 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughThis change refreshes OpenShift and cloud dependencies, adds OpenShift API contracts, updates Azure installer integration, adds GCP validation and KMS handling, extends TLS profile observation, and refreshes vendored Google and Azure clients. ChangesOpenShift API and feature contracts
Installer and TLS integration
Vendored cloud client refresh
Dependency metadata
Estimated code review effort: 5 (Critical) | ~120 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2954 +/- ##
=======================================
Coverage 50.58% 50.59%
=======================================
Files 282 282
Lines 34668 34692 +24
=======================================
+ Hits 17538 17553 +15
- Misses 15754 15763 +9
Partials 1376 1376
🚀 New features to boost your workflow:
|
|
/test e2e-vsphere |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @dlom |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following on from HIVE-3007 / #2800, subsume the upstream addition to library-go that gleans TLS curves (aka "group preferences") from the APIServer into hiveadmission (the only component that directly does TLS).
Assisted-By: cursor/grok
Summary by CodeRabbit
New Features
centos-10images.Improvements