Skip to content

pkg/operator/staticpod/startupmonitor: fix 100% cpu for loop #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alrs wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

pkg/operator/staticpod/startupmonitor: fix 100% cpu for loop #2147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/operator/staticpod/startupmonitor/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package startupmonitor
import (
"context"
"fmt"
"math"
"os"
"path/filepath"
"time"
Expand Down Expand Up @@ -201,6 +202,7 @@ func (o *Options) suicide(installerLock Locker) {
installerLock.Unlock()
klog.Info("Waiting for SIGTERM...")
for {
<-time.After(time.Duration(math.MaxInt64))

@tchap tchap Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more idiomatic way is to do select {} and be done with it.

Having said that, the right approach IMO is to pass a context into suicide and block on <-ctx.Done(). You can just pass the signal context then and be done with it.

}
}

Expand Down