Skip to content

NO-JIRA: add KMS remote-key state, annotations, and convergence helpers - #2458

Closed
tjungblu wants to merge 2 commits into
openshift:masterfrom
tjungblu:keyrot-state-ann
Closed

NO-JIRA: add KMS remote-key state, annotations, and convergence helpers#2458
tjungblu wants to merge 2 commits into
openshift:masterfrom
tjungblu:keyrot-state-ann

Conversation

@tjungblu

@tjungblu tjungblu commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add RemoteKeyState on KMS encryption key state and the secret annotation contract for target/migrated/converged remote key IDs.
  • Add read/apply/patch helpers so later rotation work can persist those annotations without rewriting unrelated secret metadata.
  • Add health-report convergence helpers to detect a unanimous remote key ID and to filter reports to the current write key.

Enhancement: openshift/enhancements#2041

Test plan

  • go test ./pkg/operator/encryption/state/ ./pkg/operator/encryption/secrets/ ./pkg/operator/encryption/kms/health/
  • CI unit/verify jobs

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tjungblu: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Add RemoteKeyState on KMS encryption key state and the secret annotation contract for target/migrated/converged remote key IDs.
  • Add read/apply/patch helpers so later rotation work can persist those annotations without rewriting unrelated secret metadata.

Enhancement: openshift/enhancements#2041

Test plan

  • go test ./pkg/operator/encryption/state/ ./pkg/operator/encryption/secrets/
  • CI unit/verify jobs

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tjungblu tjungblu changed the title NO-JIRA: add KMS remote-key rotation state and secret annotations NO-JIRA: add KMS remote-key state, annotations, and convergence helpers Sep 8, 2026
@tjungblu

tjungblu commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/close

@openshift-ci openshift-ci Bot closed this Sep 8, 2026
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@tjungblu: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants