AGENT-1522: bump InternalReleaseImage to v1 (and simplify IRI version dependency) - #6279
AGENT-1522: bump InternalReleaseImage to v1 (and simplify IRI version dependency)#6279andfasano wants to merge 4 commits into
Conversation
We don't need to actually pass around the object, just to know if it exists.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@andfasano: This pull request references AGENT-1522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThis PR migrates the InternalReleaseImage (IRI) resource from the machineconfiguration/v1alpha1 API to the v1 API across controllers, the daemon manager, the operator, bootstrap logic, and admission policy manifests. It also changes the bootstrap IRI tracking from an object reference to a boolean presence flag and bumps several unrelated go.mod dependencies. ChangesInternalReleaseImage v1 API Migration
Estimated code review effort: 3 (Moderate) | ~30 minutes Dependency Bumps
Estimated code review effort: 1 (Trivial) | ~5 minutes Related PRs: None identified. Suggested labels: api-migration, dependencies Suggested reviewers: None identified. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test ? |
|
@andfasano: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Replaced by #6280 |
This patch merges #6174 and @zaneb branch bootstrap-iri-v1.
Apart bumping the IRI version to v1, the main goal is to allow a smoother version transition, thus the changes in the Bootstrap command and Renderer (where essentially the IRI object wasn't used at all, only its presence was relevant)
Summary by CodeRabbit