Skip to content

[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump - #6418

Open
pawanpinjarkar wants to merge 2 commits into
openshift:release-4.22from
pawanpinjarkar:update-dependencies-4.22
Open

[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump#6418
pawanpinjarkar wants to merge 2 commits into
openshift:release-4.22from
pawanpinjarkar:update-dependencies-4.22

Conversation

@pawanpinjarkar

@pawanpinjarkar pawanpinjarkar commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

- What I did

Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -

go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor

This is needed because the MCO, during the bootstrap run, reads the FGs from the vendored API, that is pointing to an API version without the NoRegistryClusterInstall GAed. This change is required to make sure the bootstrap content matches 1:1 the content of the runtime MCs and other resources.

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This pull request references AGENT-1571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -

go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/test e2e-agent-compact-ipv4-iso-no-registry

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 58bb8a40-6388-461e-9a21-a797a7be93e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@bfournie

Copy link
Copy Markdown
Contributor

/test ci/prow/unit

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/test unit

@bfournie

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This PR has been marked as verified by [ci/prow/e2e-agent-compact-ipv4-iso-no-registry](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_machine-config-operator/6418/pull-ci-openshift-machine-config-operator-release-4.22-e2e-agent-compact-ipv4-iso-no-registry/2089728566945124352).

Details

In response to this:

/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

andfasano commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/retitle "[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump"

@openshift-ci openshift-ci Bot changed the title [release-4.22] AGENT-1571: Backport NoRegistryClusterInstall feature cleanup post feature promotion - Update dependencies "[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump" Aug 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This pull request references AGENT-1583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -

go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

Copy link
Copy Markdown
Contributor

/retitle [release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump

@openshift-ci openshift-ci Bot changed the title "[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump" [release-4.22] [AGENT-1583](https://redhat.atlassian.net/browse/AGENT-1583): post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump Aug 26, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

- What I did

Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -

go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

Copy link
Copy Markdown
Contributor

/retitle [release-4.22] [AGENT-1583]: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump

@openshift-ci openshift-ci Bot changed the title [release-4.22] [AGENT-1583](https://redhat.atlassian.net/browse/AGENT-1583): post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump [release-4.22] [AGENT-1583]: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump Aug 26, 2026
@andfasano

andfasano commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/retitle [release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump

@openshift-ci openshift-ci Bot changed the title [release-4.22] [AGENT-1583]: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump [release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump Aug 26, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This pull request references AGENT-1583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -

go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@andfasano: This pull request references AGENT-1583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pablintino

Copy link
Copy Markdown
Contributor

/lgtm
This is needed because the MCO, during the bootstrap run, reads the FGs from the vendored API, that is pointing to an API version without the NoRegistryClusterInstall GAed. This change is required to make sure the bootstrap content matches 1:1 the content of the runtime MCs and other resources.

@pablintino

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, pablintino, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@bfournie

Copy link
Copy Markdown
Contributor

/retest-required

@bfournie

Copy link
Copy Markdown
Contributor

Hi @pablintino @yuqi-zhang - could you add the backport-risk-assessed label and also set the jira/valid-bug?
This is covered under an existing SBAR, the same one used for the #6280 backport for example. Thank you.

@pablintino

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6d8447e and 2 for PR HEAD 037760e in total

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.