[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump - #6418
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@pawanpinjarkar: This pull request references AGENT-1571 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/test ci/prow/unit |
|
/test unit |
|
/lgtm |
|
Scheduling tests matching the |
|
/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry |
|
@pawanpinjarkar: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle "[release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump" |
|
@pawanpinjarkar: This pull request references AGENT-1583 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump |
|
@pawanpinjarkar: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.22] [AGENT-1583]: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump |
|
/retitle [release-4.22] AGENT-1583: post-feature promotion (NoRegistryClusterInstall) openshift/api dependencies bump |
|
@pawanpinjarkar: This pull request references AGENT-1583 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@andfasano: This pull request references AGENT-1583 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, pablintino, pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
Hi @pablintino @yuqi-zhang - could you add the |
|
/label backport-risk-assessed |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
Update api and client-go dependency after 4.22 feature promotion. This PR includes code changes from below steps -
go get github.com/openshift/api@release-4.22
go get github.com/openshift/client-go@release-4.22
go mod tidy; go mod vendor
This is needed because the MCO, during the bootstrap run, reads the FGs from the vendored API, that is pointing to an API version without the NoRegistryClusterInstall GAed. This change is required to make sure the bootstrap content matches 1:1 the content of the runtime MCs and other resources.
- How to verify it
/test e2e-agent-compact-ipv4-iso-no-registry
- Description for the changelog