CM-1223: [cert-manager-operator] run TLS profile e2e tests in tls-scanner job

[chiragkyal]

Summary

Add a test-tls-profile step to the tls-scanner job that runs the Feature:TLSProfile e2e suite on the standalone AWS cluster. The tls-13 step already enables the TLSAdherence feature gate and stabilizes the cluster before this step runs, and AfterAll restores the original apiserver state so tls-scanner-run is unaffected.

Exclude Feature:TLSProfile from the e2e-operator-tech-preview job to prevent the suite from being scheduled on HyperShift, where apiserver/cluster is immutable and the tests would always skip.

Context

The techpreview jobs are running in a HyperShift Cluster, where the apiserver.config.openshift.io/cluster object is immutable from inside the guest cluster.

apiserver tlsAdherence field not available on this cluster: apiservers.config.openshift.io "cluster" is forbidden: ValidatingAdmissionPolicy 'config' with binding 'config-binding' denied request: This resource cannot be created, updated, or deleted. Please ask your administrator to modify the resource in the HostedCluster object

So to run these tests need would need a standalone OCP cluster with TechPreviewNoUpgrade FeatureSet enabled.

See: openshift/cert-manager-operator#449 (comment)

Summary by CodeRabbit

• Updates OpenShift CI for cert-manager-operator.
• Adds a test-tls-profile step to the tls-scanner job for Feature:TLSProfile tests on standalone AWS clusters.
• Excludes Feature:TLSProfile from e2e-operator-tech-preview because HyperShift clusters cannot modify apiserver/cluster.
• Keeps TLS profile tests limited to clusters with TechPreviewNoUpgrade enabled.

[openshift-ci-robot]

@chiragkyal: This pull request references CM-1223 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Add a test-tls-profile step to the tls-scanner job that runs the Feature:TLSProfile e2e suite on the standalone AWS cluster. The tls-13 step already enables the TLSAdherence feature gate and stabilizes the cluster before this step runs, and AfterAll restores the original apiserver state so tls-scanner-run is unaffected.

Exclude Feature:TLSProfile from the e2e-operator-tech-preview job to prevent the suite from being scheduled on HyperShift, where apiserver/cluster is immutable and the tests would always skip.

Context

The techpreview jobs are running in a HyperShift Cluster, where the apiserver.config.openshift.io/cluster object is immutable from inside the guest cluster.

apiserver tlsAdherence field not available on this cluster: apiservers.config.openshift.io "cluster" is forbidden: ValidatingAdmissionPolicy 'config' with binding 'config-binding' denied request: This resource cannot be created, updated, or deleted. Please ask your administrator to modify the resource in the HostedCluster object

So to run these tests need would need a standalone OCP cluster with TechPreviewNoUpgrade FeatureSet enabled.

See: openshift/cert-manager-operator#449 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiragkyal
Once this PR has been reviewed and has the lgtm label, please assign mytreya-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cert-manager-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c22a62bc-7c41-442c-87c8-bd723c7e2a77

📥 Commits

Reviewing files that changed from the base of the PR and between 7886e6e and ed6aa4c.

📒 Files selected for processing (1)

• ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

The CI configuration excludes Feature:TLSProfile tests from the general tech-preview step and adds a dedicated TLS scanner step for these tests with CPU and memory requests.

Changes

TLSProfile testing

Layer / File(s)	Summary
Route TLSProfile tests to the TLS scanner step ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml	The general tech-preview filter excludes Feature:TLSProfile. The TLS scanner workflow runs the TLSProfile tests in a dedicated test-tls-profile step with resource requests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ed6aa

This localized CI configuration change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: bharath-b-rh, swghosh, arun717

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the cert-manager-operator change and the TLS profile e2e tests added to the tls-scanner job.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff adds only static CI step/filter strings; it introduces no Ginkgo It, Describe, Context, or When title and no dynamic test value.
Test Structure And Quality	✅ Passed	The PR changes only CI YAML. It adds a filtered test command and excludes a label; it adds no Ginkgo It blocks, fixtures, waits, or assertions to review.
Microshift Test Compatibility	✅ Passed	The diff changes only CI YAML: it filters an existing suite and adds a runner step. It adds no Ginkgo It/Describe/Context/When declarations or test code to assess.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only CI YAML. It adds no Ginkgo It, Describe, Context, or When test and introduces no multi-node or HA assumption.
Topology-Aware Scheduling Compatibility	✅ Passed	The changed YAML adds a TLSProfile e2e command and excludes that label from another job. No workload scheduling rule or control-plane assumption is introduced.
Ote Binary Stdout Contract	✅ Passed	The exact PR diff changes only one YAML file: a label filter and a test step; it adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only one CI YAML file; it adds no Ginkgo test code, IPv4 literals, URL construction, or external-network commands.
No-Weak-Crypto	✅ Passed	The PR adds only CI label filters, a TLSProfile test step, and resource requests; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges	✅ Passed	The PR adds only an e2e test step, label filter, and CPU/memory requests; the added lines contain no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or privilege-escalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only changes Ginkgo label filters and adds a test step with resource requests; it adds no logging commands or passwords, tokens, keys, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@chiragkyal: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cert-manager-operator-master-e2e-operator-tech-preview	openshift/cert-manager-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cert-manager-operator-master-tls-scanner	openshift/cert-manager-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[chiragkyal]

/pj-rehearse

[openshift-merge-bot]

@chiragkyal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@chiragkyal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/cert-manager-operator/master/tls-scanner	ed6aa4c	link	unknown	/pj-rehearse pull-ci-openshift-cert-manager-operator-master-tls-scanner

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[chiragkyal]

pj-rehearse result: The new step fired correctly — 1 of 175 specs matched the label filter. The test skipped due to a discriminated union bug in the current main branch test code (patching {type: Modern} without the required modern: {} sub-object). This is expected since pj-rehearse runs against main, not the feature branch. The overall step run had passed (0 failures).

So I think as far as these PR changes are concerned, we are good.