WIP: verify power-s2s uses pseries-rhel10 machine type

[Mohit-sharma46]

Summary by CodeRabbit

• Documents the required pseries-rhel10.0.0 machine type and POWER10 CPU settings for POWER10 CentOS Stream 10 hosts in the UPI libvirt installation commands.
• Adds documentation for the PowerVC IPI configuration script and its role in preparing OpenShift installations.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[Mohit-sharma46]

/test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 47b71f3b-307b-40a3-a02c-9fd6504b5119

📥 Commits

Reviewing files that changed from the base of the PR and between 24dfecf and e761629.

📒 Files selected for processing (2)

• ci-operator/step-registry/ipi/conf/powervc/ipi-conf-powervc-commands.sh
• ci-operator/step-registry/upi/install/libvirt/upi-install-libvirt-commands.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/step-registry/upi/install/libvirt/upi-install-libvirt-commands.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

Added documentation to the PowerVC IPI configuration script and the libvirt installation script. The comments describe the PowerVC setup flow and required CentOS Stream 10 POWER10 domain settings.

Changes

Installation script documentation

Layer / File(s)	Summary
Document PowerVC IPI configuration ci-operator/step-registry/ipi/conf/powervc/ipi-conf-powervc-commands.sh	Comments describe environment validation, tool installation, bastion provisioning with HAProxy, and install-config.yaml generation.
Document POWER10 domain settings ci-operator/step-registry/upi/install/libvirt/upi-install-libvirt-commands.sh	Comments document machine='pseries-rhel10.0.0' and CPU POWER10 requirements for CentOS Stream 10 on POWER10 hosts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e7616

The change is localized to two command scripts, and no actionable merge-blocking correctness, security, availability, or deployment risk remains beyond completing normal WIP checks and review.

Suggested labels: rehearsals-ack

Suggested reviewers: hamzy

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the pseries-rhel10 machine type verification documented by the changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The HEAD patch changes only shell comments; no Ginkgo test files or It/Describe/Context/When titles were added or modified, so the check's failure condition is not triggered.
Test Structure And Quality	✅ Passed	The PR changes only two shell-script comment blocks (+8 lines); the incremental diff contains no Ginkgo tests, assertions, waits, or resource setup requiring this check.
Microshift Test Compatibility	✅ Passed	The exact HEAD^..HEAD diff changes only comments in two shell scripts; it adds no Ginkgo e2e tests and introduces no MicroShift-incompatible API or feature usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The parent-to-HEAD diff changes only two shell scripts by adding comments. It adds no Ginkgo tests or test logic, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The HEAD diff adds only comments to two shell scripts; it introduces no manifests, operator/controller code, or scheduling constraints covered by this check.
Ote Binary Stdout Contract	✅ Passed	The parent-to-HEAD diff contains only eight shell comment lines; it adds no OTE binary or process-level stdout behavior.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The exact diff adds only shell comments; it introduces no Ginkgo e2e tests, IPv4 test logic, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR adds only eight shell comment lines. The diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The commit changes only eight comment lines in two shell scripts; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation setting was added.
No-Sensitive-Data-In-Logs	✅ Passed	The HEAD diff adds only shell comments; the internal IP appears only in a comment, with no new logging, password, token, API key, PII, or customer-data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Mohit-sharma46]

/test all

[Mohit-sharma46]

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.21-ocp-e2e-ovn-agent-remote-s2s-libvirt-multi-p-p

[openshift-merge-bot]

@Mohit-sharma46: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Mohit-sharma46: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-main-nightly-4.21-ocp-e2e-ovn-agent-remote-s2s-libvirt-multi-p-p	f676480	link	unknown	/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.21-ocp-e2e-ovn-agent-remote-s2s-libvirt-multi-p-p
ci/prow/ci-operator-config-metadata	ca2e88f	link	true	/test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Mohit-sharma46]

/test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mohit-sharma46
Once this PR has been reviewed and has the lgtm label, please assign amrutp-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/conf/powervc/OWNERS
• ci-operator/step-registry/upi/install/libvirt/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Mohit-sharma46: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-installer-main-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-5.2-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-5.1-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-5.0-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.23-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-powervc-ovn-multi-p-p	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-s390x-e2e	openshift/cluster-resource-override-admission-operator	presubmit	Registry content changed
periodic-ci-openshift-operator-framework-olm-release-4.23-periodics-e2e-compact-ovn-remote-libvirt-s390x-extended-f2	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.22-ocp-image-ecosystem-ovn-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.20-ocp-e2e-ovn-agent-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-image-ecosystem-ovn-remote-s2s-libvirt-multi-p-p	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-remote-libvirt-s390x	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.23-upgrade-from-nightly-4.22-ocp-ovn-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed
periodic-ci-openshift-operator-framework-olm-release-5.1-periodics-e2e-compact-ovn-remote-libvirt-s390x-extended-f2	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-s2s-libvirt-multi-p-p	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-serial-ovn-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.22-ocp-e2e-ovn-rhcos10-techpreview-remote-s2s-libvirt-multi-p-p	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-image-ecosystem-ovn-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.19-ocp-e2e-ovn-remote-libvirt-s390x	N/A	periodic	Registry content changed
periodic-ci-openshift-operator-framework-operator-controller-release-4.21-periodics-e2e-compact-ovn-remote-libvirt-s390x-extended-f2	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.19-ocp-fips-ovn-remote-s2s-libvirt-multi-p-p	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.22-ocp-e2e-ovn-remote-libvirt-s390x	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-remote-s2s-libvirt-multi-p-p	N/A	periodic	Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.18-ocp-e2e-ovn-agent-remote-libvirt-multi-z-z	N/A	periodic	Registry content changed

A total of 177 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.