Skip to content

WIP: test 4.18 - #83646

Closed
mhanss wants to merge 1 commit into
openshift:mainfrom
mhanss:test-bug-4.18
Closed

WIP: test 4.18#83646
mhanss wants to merge 1 commit into
openshift:mainfrom
mhanss:test-bug-4.18

Conversation

@mhanss

@mhanss mhanss commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Removed the cluster-health test chain from the baremetal-compact-agent-platform-none-ipv4-static-f28 test configuration for the OpenShift 4.18 nightly release.
  • Kept the associated workflow configuration unchanged.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a623c5e9-2984-41d7-b020-044565e44f7f

📥 Commits

Reviewing files that changed from the base of the PR and between d2ec2c8 and daaa0a6.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.18__amd64-nightly.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.18__amd64-nightly.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change removes the cluster-health test chain from the baremetal-compact-agent-platform-none-ipv4-static-f28 configuration. The workflow remains configured.

Changes

Cohort / File(s) Summary
Test configuration update
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.18__amd64-nightly.yaml
Removes the cluster-health test chain while preserving the workflow configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to daaa0

This is a localized configuration-only change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references testing version 4.18 but does not describe the removal of the cluster-health test chain. Replace the title with a specific summary, such as "Remove cluster-health test chain from 4.18 bare-metal configuration".
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only removes a YAML test-chain entry; it adds or changes no Ginkgo test titles or dynamic values in test names.
Test Structure And Quality ✅ Passed The only change is a two-line deletion from a CI YAML test configuration; no Ginkgo test code or It blocks changed, so these quality requirements are inapplicable.
Microshift Test Compatibility ✅ Passed The pull request only removes a YAML cluster-health chain from an existing job; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff only removes a YAML test-chain entry; it adds no Ginkgo tests or multi-node assumptions. The affected workflow remains configured.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only one CI test YAML and removes a cluster-health chain; it adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The commit changes only two YAML test-configuration lines and introduces no process-level code or stdout writes; the OTE stdout contract is therefore unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff only removes a cluster-health chain from one YAML job; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The diff only removes a cluster-health chain from one YAML test; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The commit only removes the cluster-health test entry; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR only deletes a cluster-health test chain from one YAML job; it adds no logging or sensitive values, and the workflow remains unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mhanss

mhanss commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-compact-agent-platform-none-ipv4-static-f28

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
openshift-ci Bot requested review from bmanzari and pamoedom August 19, 2026 10:08
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhanss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mhanss: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-compact-agent-platform-none-ipv4-static-f28 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@mhanss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mhanss mhanss closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant