Skip to content

Add TLS adherence and PQC readiness jobs for secrets-store-csi-driver-operator - #83650

Open
arun717 wants to merge 1 commit into
openshift:mainfrom
arun717:add_tls-scanner_sscsi_ci_job
Open

Add TLS adherence and PQC readiness jobs for secrets-store-csi-driver-operator#83650
arun717 wants to merge 1 commit into
openshift:mainfrom
arun717:add_tls-scanner_sscsi_ci_job

Conversation

@arun717

@arun717 arun717 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep optional tls-scanner for port/TLS scan + TLS 1.3 adherence (StrictAllComponents, PQC_CHECK: "false").
  • Add weekly tls-scanner-periodic with the same adherence settings.
  • Add optional tls-pqc-readiness and weekly tls-pqc-readiness-periodic with PQC_CHECK: "true".
  • Pattern aligned with openshift/release#82876 and openshift/release#83172.

Test plan

  • /pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner
  • /pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness
  • /pj-rehearse periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner-periodic periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness-periodic
  • Confirm scanner targets openshift-cluster-csi-drivers

Summary by CodeRabbit

The secrets-store-csi-driver-operator CI configuration now includes:

  • An optional weekly TLS scanner job with TLS 1.3 checks and PQC_CHECK: "false".
  • Optional PQC readiness and weekly PQC readiness jobs with PQC_CHECK: "true".
  • Azure cluster test plans for all four jobs.
  • Validation that scans target openshift-cluster-csi-drivers.

…-operator

Extend the existing tls-scanner coverage with weekly periodics and add
tls-pqc-readiness jobs (presubmit + periodic), matching the ESO/operator-sdk
TLS scanner patterns.
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9844c724-4fd0-4270-89fc-b651adfa064c

📥 Commits

Reviewing files that changed from the base of the PR and between d2ec2c8 and d341335.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

The operator CI configuration disables PQC checks for the standard TLS scanner and adds weekly TLS scanner and PQC readiness jobs using Azure clusters and the existing TLS scanner workflow.

Changes

TLS scanner CI configuration

Layer / File(s) Summary
Standard TLS scanner jobs
ci-operator/config/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main.yaml
The existing TLS scanner sets PQC_CHECK to "false". A weekly periodic TLS scanner job uses the same cluster, dependencies, environment, tests, and workflow.
PQC readiness jobs
ci-operator/config/openshift/secrets-store-csi-driver-operator/openshift-secrets-store-csi-driver-operator-main.yaml
Optional and weekly periodic PQC readiness jobs run the TLS scanner with PQC_CHECK enabled.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: 🔵 Low · up to d3413

The PR adds TLS and PQC CI jobs, but the generated CI metadata and job definitions still need updating; until that follow-up is completed, the new jobs may not be registered consistently. This is a bounded merge-readiness risk requiring explicit owner awareness.

Possibly related PRs

Suggested labels: rehearsals-ack

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the addition of TLS adherence and PQC readiness jobs described in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arun717
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from TrilokGeer and tsmetana August 19, 2026 10:21
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@arun717: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness openshift/secrets-store-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner openshift/secrets-store-csi-driver-operator presubmit Ci-operator config changed
periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner-periodic N/A periodic Periodic changed
periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness-periodic N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@arun717

arun717 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner-periodic periodic-ci-openshift-secrets-store-csi-driver-operator-main-tls-pqc-readiness-periodic

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@arun717: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant