AUTOSCALE-966: Fix release-5.0 builds for http-add-on and keda

[linkvt]

The switch to OCP images change from AUTOSCALE-966 did not include the changes required for the release-5.0 branches where the builds are now failing.

See e.g. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/branch-ci-openshift-kedacore-http-add-on-release-5.0-images/2086836208498905088

From my understanding the auto config branching does not happen anymore on the 5.0 release files which is why this fix isn't taken from the main branch config.

Related PRs:

• AUTOSCALE-966: Update dockerfile paths of kedacore-keda #82963
• AUTOSCALE-966: Update dockerfile paths of kedacore-http-add-on #83167

Summary by CodeRabbit

This PR fixes release-5.0 OpenShift CI builds for the KEDA HTTP add-on and KEDA.

• Updates image builds to use the required RHEL-specific openshift/Containerfile.*.rhel files.
• Removes the obsolete base_images definition from the KEDA release configuration.
• Sets the adapter image target to custom-metrics-autoscaler-adapter.

[openshift-ci-robot]

@linkvt: This pull request references AUTOSCALE-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

The switch to OCP images change from AUTOSCALE-966 did not include the changes required for the release-5.0 branches where the builds are now failing.

See e.g. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/branch-ci-openshift-kedacore-http-add-on-release-5.0-images/2086836208498905088

From my understanding the auto config branching does not happen anymore on the 5.0 release files which is why this fix isn't taken from the main branch config.

Related PRs:

• AUTOSCALE-966: Update dockerfile paths of kedacore-keda #82963
• AUTOSCALE-966: Update dockerfile paths of kedacore-http-add-on #83167

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fa74d42d-a572-454b-9466-e86758771667

📥 Commits

Reviewing files that changed from the base of the PR and between d2ec2c8 and ed24365.

⛔ Files ignored due to path filters (4)

• ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-release-5.0-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/kedacore-keda/openshift-kedacore-keda-release-5.0-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/kedacore-keda/openshift-kedacore-keda-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (2)

• ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-release-5.0.yaml
• ci-operator/config/openshift/kedacore-keda/openshift-kedacore-keda-release-5.0.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The release build configurations now use RHEL-specific Containerfiles. The KEDA configuration also removes the unused base image definition and updates the adapter target.

Changes

RHEL Containerfile migration

Layer / File(s)	Summary
Update release image builds ci-operator/config/openshift/kedacore-http-add-on/..., ci-operator/config/openshift/kedacore-keda/...	The HTTP add-on builds now reference RHEL Containerfiles for the operator, interceptor, and scaler. The KEDA builds use RHEL Containerfiles for the autoscaler, webhooks, and adapter, and remove the base image configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🔵 Low · up to ed243

The PR updates release-5.0 build configuration for KEDA and the HTTP add-on. It is mergeable with owner awareness: run make update and verify the generated metadata and Prow jobs stay synchronized, or builds may remain inconsistent.

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: fixing release-5.0 builds for the KEDA HTTP add-on and KEDA.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes only YAML image paths and CI sparse-checkout entries; it adds no Ginkgo test title or dynamic test-name value.
Test Structure And Quality	✅ Passed	The pull request changes only CI YAML configuration and generated job YAML; the diff contains no Ginkgo test code or cluster test operations to assess.
Microshift Test Compatibility	✅ Passed	The PR changes only CI build and job YAML; the diff adds no Ginkgo tests or test code, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only six YAML CI configuration/job files; the diff adds no Ginkgo tests or multi-node topology assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only changes CI image build paths and removes a CI base_images entry; it modifies no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only six YAML CI configuration/job files; the parent-to-HEAD patch introduces no process-level code or stdout/logging writes covered by the OTE contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only six YAML CI configuration and generated-job files; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit changes only YAML build and job paths; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or secret-comparison usage.
Container-Privileges	✅ Passed	The exact patch changes only Dockerfile paths and removes a base_images block; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, escalation, or root settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only changes image Containerfile paths, base-image configuration, and sparse-checkout entries; it adds no logging code or sensitive values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@linkvt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-kedacore-keda-release-5.0-clientset-verify	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-cma-verify-history	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-gofmt	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-govet	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-images	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-keda-e2e-aws-ovn	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-keda-e2e-gcp-ovn	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-keda-release-5.0-security	openshift/kedacore-keda	presubmit	Ci-operator config changed
pull-ci-openshift-kedacore-http-add-on-release-5.0-images	openshift/kedacore-http-add-on	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[linkvt]

/pj-rehearse pull-ci-openshift-kedacore-http-add-on-release-5.0-images

[openshift-merge-bot]

@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@linkvt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/kedacore-http-add-on/release-5.0/images	ed24365	link	unknown	/pj-rehearse pull-ci-openshift-kedacore-http-add-on-release-5.0-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[linkvt]

Image build works, failure is unrelated.

/pj-rehearse ack

[openshift-merge-bot]

@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[joelsmith]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/kedacore-http-add-on/OWNERS [joelsmith,linkvt]
• ci-operator/config/openshift/kedacore-keda/OWNERS [joelsmith,linkvt]
• ci-operator/jobs/openshift/kedacore-http-add-on/OWNERS [joelsmith,linkvt]
• ci-operator/jobs/openshift/kedacore-keda/OWNERS [joelsmith,linkvt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment