OKD-426: Make aws-upgrade job blocking for OKD SCOS 5.x nightlies

[pskrbasu]

Summary

• Remove "optional": true from the aws-upgrade job in OKD SCOS 5.0 and 5.1 nightly release controller configs (both CI and ART)
• Ensures upgrade test failures are caught at nightly acceptance time, not weeks later at promotion

Why

The OKD SCOS 5.0 upgrade job has been failing since June 29 (ec.4), but this went unnoticed for ~2 months because the nightly aws-upgrade job was optional: true. Failures only surfaced when the promoted 5-scos-next stream (where the upgrade job is required) started rejecting releases.

Full investigation in OKD-424.

What changes

File	Change
release-okd-scos-5.0-ci.json	Remove "optional": true from aws-upgrade
release-okd-scos-5.0-art.json	Remove "optional": true from aws-upgrade
release-okd-scos-5.1-ci.json	Remove "optional": true from aws-upgrade
release-okd-scos-5.1-art.json	Remove "optional": true from aws-upgrade

Dependencies

This PR should be merged after the upgrade fix PRs land in a nightly payload, otherwise all nightlies will be rejected:

• openshift/origin#31535 — auth operator Degraded exception (OCPBUGS-111997)
• openshift/installer#10771 — installer version detection fix (OCPBUGS-105510)

Test plan

• Verify origin#31535 and installer#10771 have merged
• Verify a nightly payload with both fixes passes the upgrade job
• Merge this PR to make the upgrade job blocking going forward

[openshift-ci-robot]

@pskrbasu: This pull request references OKD-426 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• Remove "optional": true from the aws-upgrade job in both OKD SCOS 5.0 nightly release controller configs
• Ensures upgrade test failures are caught at nightly acceptance time, not weeks later at promotion

Why

The OKD SCOS 5.0 upgrade job has been failing since June 29 (ec.4), but this went unnoticed for ~2 months because the nightly aws-upgrade job was optional: true. Failures only surfaced when the promoted 5-scos-next stream (where the upgrade job is required) started rejecting releases.

Full investigation in OKD-424.

What changes

File	Change
release-okd-scos-5.0-ci.json	Remove "optional": true from aws-upgrade
release-okd-scos-5.0-art.json	Remove "optional": true from aws-upgrade

Dependencies

This PR should be merged after the upgrade fix PRs land in a nightly payload, otherwise all nightlies will be rejected:

• openshift/origin#31535 — auth operator Degraded exception (OCPBUGS-111997)
• openshift/installer#10771 — installer version detection fix (OCPBUGS-105510)

Test plan

• Verify origin#31535 and installer#10771 have merged
• Verify a nightly payload with both fixes passes the upgrade job
• Merge this PR to make the upgrade job blocking going forward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f53926d3-d668-4d79-b266-dbe7129a4954

📥 Commits

Reviewing files that changed from the base of the PR and between 1ddcc1d and 1fbb7da.

📒 Files selected for processing (2)

• core-services/release-controller/_releases/release-okd-scos-5.0-art.json
• core-services/release-controller/_releases/release-okd-scos-5.0-ci.json

💤 Files with no reviewable changes (2)

• core-services/release-controller/_releases/release-okd-scos-5.0-ci.json
• core-services/release-controller/_releases/release-okd-scos-5.0-art.json

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

Walkthrough

The release configurations no longer mark the aws-upgrade verification as optional. Retry limits, Prow jobs, and upgrade behavior remain unchanged.

Changes

AWS upgrade verification

Layer / File(s)	Summary
Make AWS upgrade verification required core-services/release-controller/_releases/release-okd-scos-5.0-art.json, core-services/release-controller/_releases/release-okd-scos-5.0-ci.json	Removes optional: true from the aws-upgrade verification entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1fbb7

This PR makes the aws-upgrade job blocking in two nightly release configurations. No actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• openshift/release#82665: Changes CI verification jobs from optional to required in different configurations.
• openshift/release#83630: Modifies verification settings in the same CI configuration for a different job.

Suggested labels: do-not-merge/work-in-progress, rehearsals-ack, jira/valid-reference

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff only removes optional: true from two JSON release configurations; it changes no Ginkgo tests or test titles, so no unstable test name is introduced.
Test Structure And Quality	✅ Passed	The commit changes only two release-controller JSON files and no Ginkgo test code; the stated test-quality requirements are therefore not applicable.
Microshift Test Compatibility	✅ Passed	The HEAD patch changes only two JSON release configurations by removing optional; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two release-controller JSON files by removing aws-upgrade optionality; it adds no Ginkgo e2e tests or multi-node test assumptions, so this check is inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only removes optional from two release-controller JSON verification entries; it adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The HEAD diff changes only two release-controller JSON files and removes one config key; it introduces no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only two release-controller JSON files by removing aws-upgrade optional flags; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The parent-to-HEAD diff contains only two deletions of "optional": true; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, or timing-sensitive comparison code.
Container-Privileges	✅ Passed	The exact diff only removes optional: true from two release-controller JSON files; privilege-token and parsed-field scans found no flagged settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only deletes "optional": true in two JSON files. No logging code or sensitive values were added; all aws-upgrade values remain unchanged.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: making the aws-upgrade job blocking for OKD SCOS 5.x nightlies.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@pskrbasu: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@pskrbasu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, pskrbasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/release-controller/_releases/OWNERS [bradmwilliams]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment