Skip to content

ROSAENG-66745 | add: Focus variable to run a specific test case - #3530

Open
elveeram wants to merge 3 commits into
openshift:hyperfleet-v2from
elveeram:hyperfleet-v2
Open

ROSAENG-66745 | add: Focus variable to run a specific test case#3530
elveeram wants to merge 3 commits into
openshift:hyperfleet-v2from
elveeram:hyperfleet-v2

Conversation

@elveeram

@elveeram elveeram commented Sep 10, 2026

Copy link
Copy Markdown

Please provide enough context so reviewers can understand:

  1. the problem: Need a focus variable while running specific tests for Hyperfleet V2.
  2. why this change is needed: So the ginkgo command runs only the test that is provided.
  3. what changed.: The make target with the new focus variable
  4. how you validated it: Ran the make command.
  • Modified Makefile e2e-hyperfleet target:
    • Added documentation for new variables: FOCUS, TEST_PROFILE, TEST_PROFILE_DIR, WORKSPACE
    • Changed env vars to use export instead of inline assignment
    • Added new exported variables: TEST_PROFILE, TEST_PROFILE_DIR, WORKSPACE
    • Added ROSA_CLI_FOCUS variable support with --focus flag: $${ROSA_CLI_FOCUS:+--focus "$$ROSA_CLI_FOCUS"}

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b4a3b488-6d94-44f2-b80c-0ee3426d73c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elveeram
Once this PR has been reviewed and has the lgtm label, please assign jerichokeyne for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olucasfreitas

Copy link
Copy Markdown
Contributor

@elveeram please fill out the description correctly so we can start to review this

@elveeram

elveeram commented Sep 11, 2026

Copy link
Copy Markdown
Author

@elveeram please fill out the description correctly so we can start to review this

I can't seem to change the description. I have some items written but it does not show in Preview:
Monosnap [ROSAENG-66745](https://redhat.atlassian.net/browse/ROSAENG-66745) | add: Focus va…equest #3530 · openshift:rosa 2026-09-11 10-39-10

I did Update comment.

@olucasfreitas

olucasfreitas commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@elveeram ah sorry, I thought this was related to V1 stuff, you should probably reach out to @gdbranco to get this reviewed

@elveeram

elveeram commented Sep 11, 2026

Copy link
Copy Markdown
Author

@elveeram ah sorry, I thought this was related to V1 stuff, you should probably reach out to @gdbranco to get this reviewed

@elveeram please fill out the description correctly so we can start to review this

I can't seem to change the description. I have some items written but it does not show in Preview: Monosnap [ROSAENG-66745](https://redhat.atlassian.net/browse/ROSAENG-66745) | add: Focus va…equest #3530 · openshift:rosa 2026-09-11 10-39-10

I did Update comment.

There was the comment tag. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants