[edpm_deploy_baremetal] Wait for provision server CR Ready

[rabi]

Deploy was gating on the provision server Deployment reaching condition=Available, then immediately reading
status.localImageUrl / status.localImageChecksumUrl from the OpenStackProvisionServer CR.

This results in race and job failures intermittently.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f97eb67-6bee-424c-abaa-579836e06bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 9896820 and 8897388.

📒 Files selected for processing (1)

• roles/edpm_deploy_baremetal/tasks/main.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved provision-server readiness checks by monitoring the reported readiness of the provisioning resource.
  • Enhanced checksum validation by using the resource’s current local checksum URL.
  • Removed reliance on a fallback checksum URL, improving validation accuracy.

Walkthrough

The bare-metal deployment readiness check now waits for the OpenStackProvisionServer custom resource to become Ready. Checksum URL validation now reads status.localImageChecksumUrl directly.

Changes

Provision server readiness

Layer / File(s)	Summary
CR readiness and checksum validation roles/edpm_deploy_baremetal/tasks/main.yml	The task waits for the OpenStackProvisionServer Ready condition before validating checksum reachability. The checksum check uses status.localImageChecksumUrl directly.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 88973

This change waits for the provision server custom resource to become ready before reading its status values; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the change to wait for the provision server custom resource to become Ready.
Description check	✅ Passed	The description explains the readiness race and the change’s effect on intermittent deployment failures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/1d3ba7e57bfd4659b0eff173f01e1559

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 41m 01s
❌ cifmw-crc-podified-edpm-baremetal NODE_FAILURE Node(set) request 099-0000175050 failed in 0s
❌ cifmw-crc-podified-edpm-baremetal-minor-update NODE_FAILURE Node(set) request 099-0000175051 failed in 0s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 52s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 1h 09m 43s
❌ cifmw-crc-podified-edpm-baremetal-bootc NODE_FAILURE Node(set) request 099-0000175109 failed in 0s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 40s
✔️ cifmw-molecule-edpm_deploy_baremetal SUCCESS in 6m 09s

[rabi]

recheck

[evallesp]

/lgtm

[rabi]

Folks can we merge this to avoid intermittent failures like https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/logs//eb0/rdoproject.org/eb0b127aace8487b81f25d2c577b642b/ ?

[abays]

/lgtm
/approve

[nemarjan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, nemarjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [nemarjan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment