Fix bug in problemRandomize hardcopy. - #1516
Merged
Alex-Jordan merged 1 commit intoAug 18, 2026
Merged
Conversation
When generating hardcopy with a problem using problemRandomize, `$input_ref` doesn't contain the `user` or `effectiveUser` keys, which causes an error when trying to compare them. Only compare if `user` and `efficitveUser` are equal in the case `effectiveUser` is a defined key in `$input_ref`. Fixes openwebwork#1515.
drgrice1
approved these changes
Aug 17, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
Looks good for this broken macro!
Alex-Jordan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating hardcopy with a problem using problemRandomize,
$input_refdoesn't contain theuseroreffectiveUserkeys, which causes an error when trying to compare them. Only compare ifuserandefficitveUserare equal in the caseeffectiveUseris a defined key in$input_ref.Fixes #1515.
Note this is just a quick fix, as the macro is deprecated and there could probably be other issues with its approach.