prometheus-node-exporter-lua: add unbound stats collector#29091
Open
marinierb wants to merge 3 commits into
Open
prometheus-node-exporter-lua: add unbound stats collector#29091marinierb wants to merge 3 commits into
marinierb wants to merge 3 commits into
Conversation
added 2 commits
April 7, 2026 15:56
Signed-off-by: marinierb <notareal@email.address>
Signed-off-by: marinierb <bmgm41@gmail.com> Signed-off-by: marinierb <notareal@email.address>
Author
|
@champtar For your review. Thanks! |
marinierb
changed the title
Member
|
Previous PR: #28784 |
champtar
requested changes
May 25, 2026
Comment on lines
+42
to
+53
| local chunks = {} | ||
| while true do | ||
| local chunk, err, partial = sock:receive(4096) | ||
| if partial and partial ~= "" then | ||
| chunks[#chunks + 1] = partial | ||
| end | ||
| if not chunk then break end | ||
| chunks[#chunks + 1] = chunk | ||
| end | ||
| sock:close() | ||
|
|
||
| local out = table.concat(chunks) |
Member
There was a problem hiding this comment.
Have you tried sock:receive("*a") ?
Signed-off-by: marinierb <notareal@email.address>
champtar
requested changes
Jun 6, 2026
Member
champtar
left a comment
champtar
left a comment
There was a problem hiding this comment.
Getting really close, while you fix the review please rebase
| define Package/prometheus-node-exporter-lua-unbound | ||
| $(call Package/prometheus-node-exporter-lua/Default) | ||
| TITLE+= (unbound stats collector) | ||
| DEPENDS:=prometheus-node-exporter-lua +unbound-control |
Member
There was a problem hiding this comment.
Now that we are using the unix socket we don't need unbound-control
Suggested change
| DEPENDS:=prometheus-node-exporter-lua +unbound-control | |
| DEPENDS:=prometheus-node-exporter-lua +unbound-daemon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 prometheus-node-exporter-lua
Maintainer: @champtar
Description: Add a collector for unbound statistics
Run Testing Details
Signed-off-by: Bruno Marinier bmgm41@gmail.com