zfs_vnops_windows: fix volume disk extent length - #586
Open
lideming wants to merge 1 commit into
Open
Conversation
Use refdbytes + availbytes for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS. This matches the other disk and partition size handlers. Also zero-initialize several output buffers before filling the returned fields. Signed-off-by: lideming <me@yuuza.net>
|
This looks great thanks. You used the correct branch, I go back and populate the Development branch periodically but haven't had the time lately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted at
zfs-Windows-2.4.1-releasebecause it is the currentzfswin-2.4.1rc11release branch. Please let me know ifdevelopmentis preferred.Motivation and Context
(Task Manager showing the incorrect volume size before the fix)
The volume disk extent handler should report the same byte count used by the other disk and partition size handlers.
Description
Use
refdbytes + availbytesforIOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS.Also zero-initialize several disk geometry and partition output buffers before filling the fields OpenZFS returns.
How Has This Been Tested?
By Agent:
zfswin-2.4.1rc11.zpool sync, and verified SHA256 readback.zpool statusremainedONLINEwith no known data errors.By Human:
Types of changes
Checklist:
Signed-off-by.