Combinator builder frontend#1186
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 78 78
Lines 4711 4711
=======================================
Hits 4358 4358
Misses 353 353 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
audiodude
requested changes
Jun 11, 2026
audiodude
left a comment
Member
There was a problem hiding this comment.
This looks really good! I think the main thing from an architecture perspective is thinking through when helper methods in the component make sense, versus when they're distracting. Not every @click handler needs to use a helper, but that also doesn't mean that none of them should!
a9b9894 to
0e1ea13
Compare
audiodude
reviewed
Jun 16, 2026
0e1ea13 to
428e57c
Compare
Collaborator
Author
|
I rebased the branch onto latest |
audiodude
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the frontend create/edit flow for Combinator selections.
Summary: