Skip to content

Combinator builder frontend#1186

Merged
audiodude merged 6 commits into
mainfrom
combinator_builder_frontend
Jun 17, 2026
Merged

Combinator builder frontend#1186
audiodude merged 6 commits into
mainfrom
combinator_builder_frontend

Conversation

@ziaddevv

@ziaddevv ziaddevv commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Adds the frontend create/edit flow for Combinator selections.

Summary:

  • Adds a Combinator builder page for selecting include/exclude builders.
  • Supports union/intersection operations for each group.
  • Wires Combinator routes and navigation.
  • Adds frontend validation
  • Adds Cypress coverage for create, edit, validation, error states, and My Selections navigation.

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (41f25e8) to head (4f20201).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files          78       78           
  Lines        4711     4711           
=======================================
  Hits         4358     4358           
  Misses        353      353           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@audiodude audiodude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I think the main thing from an architecture perspective is thinking through when helper methods in the component make sense, versus when they're distracting. Not every @click handler needs to use a helper, but that also doesn't mean that none of them should!

Comment thread wp1-frontend/src/components/CombinatorBuilder.vue Outdated
Comment thread wp1-frontend/src/components/CombinatorBuilder.vue Outdated
Comment thread wp1-frontend/src/components/SecondaryNav.vue
Comment thread wp1-frontend/src/components/CombinatorBuilder.vue
@ziaddevv ziaddevv force-pushed the combinator_builder_frontend branch from a9b9894 to 0e1ea13 Compare June 12, 2026 00:17
Comment thread wp1-frontend/src/components/CombinatorBuilder.vue Outdated
@ziaddevv ziaddevv force-pushed the combinator_builder_frontend branch from 0e1ea13 to 428e57c Compare June 16, 2026 20:06
@ziaddevv

Copy link
Copy Markdown
Collaborator Author

I rebased the branch onto latest origin/main,removed Combinator from the nav for now and renamed the loading flag to buildersFetchFinished.

Comment thread wp1-frontend/src/components/CombinatorBuilder.vue Outdated
@audiodude audiodude added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 8097c8e Jun 17, 2026
7 checks passed
@audiodude audiodude deleted the combinator_builder_frontend branch June 17, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants