Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 92.50% 92.57% +0.06%
==========================================
Files 78 78
Lines 4711 4712 +1
==========================================
+ Hits 4358 4362 +4
+ Misses 353 350 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
audiodude
force-pushed
the
1180-fix
branch
4 times, most recently
from
185835c to
c1b3b6a
Compare
ziaddevv
reviewed
Jun 12, 2026
AbstractBuilder.materialize now validates the builder params before calling build(), raising Wp1RetryableSelectionError (saved as a CAN_RETRY selection with error messages) when validation fails. The equivalent error check is refactored out of SimpleBuilder.build, which now uses validate() only for list normalization. Fixes #1180 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractBuilder.materialize now validates the builder params before calling build(), raising Wp1RetryableSelectionError (saved as a CAN_RETRY selection with error messages) when validation fails. The equivalent error check is refactored out of SimpleBuilder.build, which now uses validate() only for list normalization.
Fixes #1180