Skip to content

[Kotlin LSP] Do not download extra Java. #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opcode81 merged 10 commits into from
Feb 27, 2026
Merged

[Kotlin LSP] Do not download extra Java. #1079

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cc0e2af
Reuse java and kotlin if possible
cx-alberto-simoes Feb 24, 2026
1a17a33
Minor tweaks
cx-alberto-simoes Feb 24, 2026
64b4086
Compute JAVA_HOME
cx-alberto-simoes Feb 24, 2026
927b088
Linting
cx-alberto-simoes Feb 24, 2026
57048cc
Simplify Kotlin
cx-alberto-simoes Feb 25, 2026
8eff695
poe
cx-alberto-simoes Feb 25, 2026
8c5b82d
Remove unuised comment
cx-alberto-simoes Feb 25, 2026
ca547c0
Fix docs
cx-alberto-simoes Feb 25, 2026
31d6d7d
Remove looking up in the path
cx-alberto-simoes Feb 25, 2026
10f08eb
Revert
cx-alberto-simoes Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 2 additions & 55 deletions src/solidlsp/language_servers/kotlin_language_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,40 +53,6 @@
"osx-arm64": "mac-aarch64",
}

# Java runtime dependency information per platform
JAVA_DEPENDENCIES = {
"win-x64": {
"url": "https://github.com/redhat-developer/vscode-java/releases/download/v1.42.0/java-win32-x64-1.42.0-561.vsix",
"archiveType": "zip",
"java_home_path": "extension/jre/21.0.7-win32-x86_64",
"java_path": "extension/jre/21.0.7-win32-x86_64/bin/java.exe",
},
"linux-x64": {
"url": "https://github.com/redhat-developer/vscode-java/releases/download/v1.42.0/java-linux-x64-1.42.0-561.vsix",
"archiveType": "zip",
"java_home_path": "extension/jre/21.0.7-linux-x86_64",
"java_path": "extension/jre/21.0.7-linux-x86_64/bin/java",
},
"linux-arm64": {
"url": "https://github.com/redhat-developer/vscode-java/releases/download/v1.42.0/java-linux-arm64-1.42.0-561.vsix",
"archiveType": "zip",
"java_home_path": "extension/jre/21.0.7-linux-aarch64",
"java_path": "extension/jre/21.0.7-linux-aarch64/bin/java",
},
"osx-x64": {
"url": "https://github.com/redhat-developer/vscode-java/releases/download/v1.42.0/java-darwin-x64-1.42.0-561.vsix",
"archiveType": "zip",
"java_home_path": "extension/jre/21.0.7-macosx-x86_64",
"java_path": "extension/jre/21.0.7-macosx-x86_64/bin/java",
},
"osx-arm64": {
"url": "https://github.com/redhat-developer/vscode-java/releases/download/v1.42.0/java-darwin-arm64-1.42.0-561.vsix",
"archiveType": "zip",
"java_home_path": "extension/jre/21.0.7-macosx-aarch64",
"java_path": "extension/jre/21.0.7-macosx-aarch64/bin/java",
},
}


class KotlinLanguageServer(SolidLanguageServer):
"""
Expand Down Expand Up @@ -135,32 +101,13 @@ def _get_or_install_core_dependency(self) -> str:
kotlin_suffix = PLATFORM_KOTLIN_SUFFIX.get(platform_id.value)
assert kotlin_suffix, f"Unsupported platform for Kotlin LSP: {platform_id.value}"

java_dependency = JAVA_DEPENDENCIES[platform_id.value]

# Setup paths for dependencies
static_dir = os.path.join(self._ls_resources_dir, "kotlin_language_server")
os.makedirs(static_dir, exist_ok=True)

# Setup Java
java_dir = os.path.join(static_dir, "java")
os.makedirs(java_dir, exist_ok=True)

self._java_home_path = os.path.join(java_dir, java_dependency["java_home_path"])
java_path = os.path.join(java_dir, java_dependency["java_path"])

if not os.path.exists(java_path):
log.info(f"Downloading Java for {platform_id.value}...")
FileUtils.download_and_extract_archive(java_dependency["url"], java_dir, java_dependency["archiveType"])
if not platform_id.value.startswith("win-"):
os.chmod(java_path, 0o755)

assert os.path.exists(java_path), f"Java executable not found at {java_path}"

# Setup Kotlin Language Server
if platform_id.value.startswith("win-"):
kotlin_script = os.path.join(static_dir, "kotlin-lsp.cmd")
else:
kotlin_script = os.path.join(static_dir, "kotlin-lsp.sh")
kotlin_script_name = "kotlin-lsp.cmd" if platform_id.value.startswith("win-") else "kotlin-lsp.sh"
kotlin_script = os.path.join(static_dir, kotlin_script_name)

if not os.path.exists(kotlin_script):
kotlin_lsp_version = self._custom_settings.get("kotlin_lsp_version", DEFAULT_KOTLIN_LSP_VERSION)
Expand Down
Loading