fix: query_project rejected read-only tools excluded by the current context#1537
Open
bor wants to merge 1 commit into
Open
fix: query_project rejected read-only tools excluded by the current context#1537bor wants to merge 1 commit into
bor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal follow-up to #1527 per @opcode81's review: drop the
is_active()assertion inQueryProjectTool.applyso a read-only tool hidden by the caller's current context (e.g.search_for_patternin theclaude-codecontext, where the client has native grep) can still be forwarded to another registered project.The
is_readonly()guard is unchanged; nothing else is touched.Changes
src/serena/tools/query_project_tools.py: remove theassert tool.is_active()line.CHANGELOG.md: short entry under# Unreleased (main)/* Tools:.Test plan
claude-codecontext (which excludessearch_for_pattern), forwardsearch_for_patternto another registered project viaquery_projectand confirm it succeeds.