release-notes: document quorum queues default - #1073
Open
jklare wants to merge 1 commit into
Open
Conversation
The kolla default om_enable_rabbitmq_quorum_queues was changed from
false to true in the defaults repository with commit bf60e0f ("kolla:
make quorum queues the default", osism/defaults#235) on 2024-10-13.
Neither that commit nor the release notes mentioned the change.
Tracing defaults_version from the release manifests shows that OSISM
8.0.2 pins defaults v0.20240924.0 (false), while 8.1.0 pins
v0.20250113.0 (true). The new default therefore first shipped with
OSISM 8.1.0 and is also in effect in 9.0.0. Deployments that upgrade
from 8.0.x to 9 cross the change on that hop, which is where it has
been reported from the field.
Configuration repositories created before October 2024 do not carry
the parameter at all, so they silently pick up the new default and all
OpenStack services start declaring their RPC and notification queues
as quorum queues instead of classic queues. An existing classic queue
cannot be redeclared as a quorum queue, and the affected services fail
as long as the old queues are still present.
The new default is intended for new clusters. A migration path for
existing deployments was only developed for OSISM 10, where the
RabbitMQ 3 to RabbitMQ 4 migration and the accompanying
"osism migrate rabbitmq3to4" command handle the switch. Document the
change in the 8.1.0 upgrade notes with the recommendation to set the
parameter explicitly to false before upgrading, and add a pointer with
the same recommendation to the 9.0.0 section, since that is the release
most deployments encounter the change with.
UpgradeImpact
Assisted-by: Claude:claude-opus-5[1m]
Signed-off-by: Jan Klare <klare@osism.tech>
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It was reported that an upgrade from OSISM 8 to OSISM 9 switched all RabbitMQ queues from classic to quorum, and that this is not covered by our release notes.
What changed
The parameter is
om_enable_rabbitmq_quorum_queues. It was flipped fromfalsetotruein osism/defaults#235 (commitbf60e0f, 2024-10-13), with the matching change in osism/cfg-cookiecutter#674 one minute later. Neither commit carried a release note.Which release shipped it
Tracing
defaults_versionfrom the release manifests against the flag value in eachdefaultstag:defaults_versionom_enable_rabbitmq_quorum_queuesv0.20240924.0falsev0.20250113.0truev0.20250407.0trueSo the default first shipped with OSISM 8.1.0, not 9.0.0. Deployments upgrading from 8.0.x to 9 cross it on that hop, which explains the report.
Configuration repositories created before October 2024 do not carry the parameter at all, so they pick up the new default silently.
testbed/environments/kolla/configuration.ymlstill pinsfalse, so CI never exercised the transition.What this adds
Upgrade notessubsection in the 8.1.0 release notes stating that the new default is intended for new clusters, not for upgraded ones, with the recommendation to set the parameter explicitly tofalsebefore upgrading to 8.1 or 9. The switch was not tested for 8.1/9 and a migration path was only developed for OSISM 10, so the note points at the RabbitMQ 3 to RabbitMQ 4 migration and makes clear thatosism migrate rabbitmq3to4only exists in OSISM 10.Verification
yarn buildsucceeds withonBrokenLinks: 'throw', so both cross-file anchors resolve.Not included
docs/concepts/technology-adaptability.mdstill describes the old approach as "RabbitMQ 3 (classic queues)", which is inaccurate for 8.1/9 defaults. Left out to keep this change focused; happy to fold it in.