feat: add --completions flag for shell completion generation (1) - #931
feat: add --completions flag for shell completion generation (1)#931marcospb19 wants to merge 5 commits into
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # src/cli/args.rs
|
Don't we already generate shell completions at build time? Are there any benefits to also do this at run time? |
|
Thanks, that's a valid point, maybe we should just leave it as it is, I mean, if you are packaging targetted for the latest commit in |
|
This would be really helpful. I came across this issue looking for completions for zsh. For example in my setup I'm using zinit for zsh and it needs a way to get the completions |
|
@dimpen thanks, I'm reconsidering, provided that I manage to simplify this code and I don't see a huge binary size increase, I might include this in and switch away from build-time completions generation. |
Reopening PR #896.
(Branch for this PR was erased, but it had our license.)